Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): revert filter code that breaks search in docs #2425

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

matthewmayer
Copy link
Contributor

This reverts commit de0768c.

Fixes #2336

This reverts commit de0768c.

# Conflicts:
#	docs/api/ApiIndex.vue
@matthewmayer matthewmayer requested a review from a team September 25, 2023 09:37
@matthewmayer matthewmayer requested a review from a team as a code owner September 25, 2023 09:37
@matthewmayer matthewmayer self-assigned this Sep 25, 2023
@matthewmayer matthewmayer added c: bug Something isn't working c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #2425 (4cbf391) into next (9b58fe3) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2425      +/-   ##
==========================================
- Coverage   99.61%   99.59%   -0.02%     
==========================================
  Files        2802     2802              
  Lines      252492   252492              
  Branches     1104     1095       -9     
==========================================
- Hits       251510   251481      -29     
- Misses        955      984      +29     
  Partials       27       27              

see 1 file with indirect coverage changes

@ST-DDT ST-DDT added this to the vAnytime milestone Sep 25, 2023
@ST-DDT ST-DDT requested review from a team September 25, 2023 10:50
@ST-DDT ST-DDT merged commit c498c09 into faker-js:next Sep 28, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI bug in search bar on the faker.js website
3 participants