Skip to content

Commit c0d92b8

Browse files
authoredDec 29, 2024··
fix(system): semver parts should not be limited to 0-9 (#3349)
1 parent e6d27a3 commit c0d92b8

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed
 

‎src/modules/system/index.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -213,15 +213,15 @@ export class SystemModule extends ModuleBase {
213213
* Returns a [semantic version](https://semver.org).
214214
*
215215
* @example
216-
* faker.system.semver() // '1.1.2'
216+
* faker.system.semver() // '1.15.2'
217217
*
218218
* @since 3.1.0
219219
*/
220220
semver(): string {
221221
return [
222222
this.faker.number.int(9),
223-
this.faker.number.int(9),
224-
this.faker.number.int(9),
223+
this.faker.number.int(20),
224+
this.faker.number.int(20),
225225
].join('.');
226226
}
227227

‎test/modules/__snapshots__/internet.spec.ts.snap

+1-1
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ exports[`internet > 1211 > url > with slash appended 1`] = `"https://velvety-tar
254254

255255
exports[`internet > 1211 > url > without slash appended and with http protocol 1`] = `"http://velvety-tarragon.biz"`;
256256

257-
exports[`internet > 1211 > userAgent 1`] = `"Mozilla/5.0 (Linux; Android 13; SM-G998B) AppleWebKit/605.67 (KHTML, like Gecko) Chrome/107.7.3.6 Mobile Safari/592.76"`;
257+
exports[`internet > 1211 > userAgent 1`] = `"Mozilla/5.0 (Linux; Android 13; SM-G998B) AppleWebKit/605.67 (KHTML, like Gecko) Chrome/107.7.7.14 Mobile Safari/592.76"`;
258258

259259
exports[`internet > 1211 > userName > noArgs 1`] = `"Tito67"`;
260260

‎test/modules/__snapshots__/system.spec.ts.snap

+3-3
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ exports[`system > 42 > networkInterface > with {"interfaceType":"ww"} 1`] = `"ww
7878

7979
exports[`system > 42 > networkInterface > with {} 1`] = `"wlp5s1f0"`;
8080

81-
exports[`system > 42 > semver 1`] = `"3.9.7"`;
81+
exports[`system > 42 > semver 1`] = `"3.19.15"`;
8282

8383
exports[`system > 1211 > commonFileExt 1`] = `"shtml"`;
8484

@@ -158,7 +158,7 @@ exports[`system > 1211 > networkInterface > with {"interfaceType":"ww"} 1`] = `"
158158

159159
exports[`system > 1211 > networkInterface > with {} 1`] = `"P9wwp6s6d6"`;
160160

161-
exports[`system > 1211 > semver 1`] = `"9.8.2"`;
161+
exports[`system > 1211 > semver 1`] = `"9.18.4"`;
162162

163163
exports[`system > 1337 > commonFileExt 1`] = `"wav"`;
164164

@@ -238,4 +238,4 @@ exports[`system > 1337 > networkInterface > with {"interfaceType":"ww"} 1`] = `"
238238

239239
exports[`system > 1337 > networkInterface > with {} 1`] = `"eno2"`;
240240

241-
exports[`system > 1337 > semver 1`] = `"2.1.2"`;
241+
exports[`system > 1337 > semver 1`] = `"2.3.5"`;

0 commit comments

Comments
 (0)
Please sign in to comment.