Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win11 Correct Detection (Client Hints) #698

Open
dawesi opened this issue Dec 29, 2023 · 2 comments
Open

Win11 Correct Detection (Client Hints) #698

dawesi opened this issue Dec 29, 2023 · 2 comments

Comments

@dawesi
Copy link

dawesi commented Dec 29, 2023

Library version

Describe the bug
Windows 11 is detected incorrectly as brower UA shows win10

To Reproduce

Use Firefox/Edge on Win11

Expected behavior
OS Major Version 11

Screenshots

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Firefox or Edge

Additional context

More context here: https://developers.whatismybrowser.com/learn/browser-detection/user-agents/detect-windows-11-user-agent


Microsoft provide detection script for detecting windows version 11 and greater here:

https://learn.microsoft.com/en-us/microsoft-edge/web-platform/how-to-detect-win11#sample-code-for-detecting-windows-11

ie:

navigator.userAgentData.getHighEntropyValues(["platformVersion"])
 .then(ua => {
   if (navigator.userAgentData.platform === "Windows") {
     const majorPlatformVersion = parseInt(ua.platformVersion.split('.')[0]);
     if (majorPlatformVersion >= 13) {
       console.log("Windows 11 or later");
      }
      else if (majorPlatformVersion > 0) {
        console.log("Windows 10");
      }
      else {
        console.log("Before Windows 10");
      }
   }
   else {
     console.log("Not running on Windows");
   }
 });

@ghost
Copy link

ghost commented Jan 7, 2024

it is detected correctly for me. possibly not defining the client hints correctly
win11

@faisalman
Copy link
Owner

Can you provide a screenshot of whats being displayed in https://uaparser.js.org/ ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants