Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS devices not read with detail model information #520

Closed
qingzhuozhen opened this issue Sep 6, 2021 · 2 comments
Closed

iOS devices not read with detail model information #520

qingzhuozhen opened this issue Sep 6, 2021 · 2 comments

Comments

@qingzhuozhen
Copy link

It seems for apple devices, the library is not reading detail model information but just general iphone, ipad, etc. For example, for user agent Mozilla/5.0 (iPhone; CPU iPhone OS 13_3_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/15E148 [FBAN/FBIOS;FBDV/iPhone12,5;FBMD/iPhone;FBSN/iOS;FBSV/13.3.1;FBSS/3;FBID/phone;FBLC/en_US;FBOP/5;FBCR/] the library is reading device model as iPhone, but not iPhone12,5, which could tell this is from iPhone 11 Pro Max. Ideally we should have mode detail model information in devices if possible.
@qingzhuozhen qingzhuozhen mentioned this issue Sep 6, 2021
Closed
@qingzhuozhen
Copy link
Author

Just created an PR #521 to fix this issue

@faisalman
Copy link
Owner

Fixed in a1d816a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faisalman @qingzhuozhen