Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not work with the latest brave browser #498

Closed
chaitanyapotti opened this issue Jun 2, 2021 · 4 comments
Closed

Does not work with the latest brave browser #498

chaitanyapotti opened this issue Jun 2, 2021 · 4 comments

Comments

@chaitanyapotti
Copy link

Here's the result from brave browser

image
@edwinbbu
Copy link

edwinbbu commented Jul 5, 2021

getBrowser() return Chrome instead of Brave

@PlussRolf
Copy link

Same here, tested on standalone lastest versión and online.

image
image

@stefanboz
Copy link

Still not working as of March 10th 2022

image

@faisalman
Copy link
Owner

This is the intended behavior for Brave, quoting from brave/brave-browser#1052 (comment), they ultimately decided to remove specific Brave user-agent string

As a general policy, we don't want the user-agent string to make Brave users much more distinctive. Our general ballpark plan is to switch to a Brave UA when users on that platform will have an anonymity set of about a million.

faisalman added a commit that referenced this issue Feb 22, 2023
@faisalman
Fix #498 - Detect Brave Browser by checking navigator.brave
2c0a380 
brave/brave-browser#10165 (comment)
faisalman added a commit that referenced this issue Feb 25, 2023
@faisalman
Fix #498 - Detect Brave Browser by checking navigator.brave

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
03b0a5a 
brave/brave-browser#10165 (comment)
faisalman added a commit that referenced this issue Mar 4, 2023
@faisalman
Fix #498 - Detect Brave Browser by checking navigator.brave
73c2577 
brave/brave-browser#10165 (comment)
(cherry picked from commit 03b0a5a)
@faisalman faisalman mentioned this issue Oct 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@faisalman @chaitanyapotti @PlussRolf @edwinbbu @stefanboz