Added workflows/test.yml + fixed tests #196
Merged
+2,036
−1,686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can take a look on action result on my fork : https://github.com/jbigman/app-store-scraper/actions |
|
up |
facundoolano
approved these changes
Oct 24, 2023
|
Not sure why this isn't triggering from the PR. I will merge to see if next one runs it. |
|
If you have the bandwidth, could you send another one to remove the travis.yml file, and perhaps replacing the status badge in the README? (don't remember if github actions have badges, but otherwise removing the current one would ok as well) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @facundoolano, i made a github action similar to the play-store-scrapper one. This way it will be possible to merge other pull requests in the pipe.
This PR also contains fixes in tests
I currently removed the npm audit because this project uses the deprecated "request" library.