Fix code example typo in homepage #3290
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
There was a problem hiding this comment.
@kassens has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
alunyov
pushed a commit
that referenced
this pull request
Dec 16, 2020
Summary: Code sample in homepage imports fragment container `ArtistHeader` but returns nonexistent `Artist` component. Alternatively the intention might have been to show `QueryRenderer` rendering an `Artist` component-that isn't shown in the examples-which presumably renders `ArtistHeader` at some point in its tree. Then the import statement should be changed instead. Pull Request resolved: #3290 Reviewed By: alunyov Differential Revision: D25423861 Pulled By: kassens fbshipit-source-id: 825778c1f8703cac01a08aec37315e67876a0f2a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code sample in homepage imports fragment container
ArtistHeaderbut returns nonexistentArtistcomponent.Alternatively the intention might have been to show
QueryRendererrendering anArtistcomponent-that isn't shown in the examples-which presumably rendersArtistHeaderat some point in its tree. Then the import statement should be changed instead.