Skip to content

Commit bede32d

Browse files
alunyovfacebook-github-bot
authored andcommittedJan 13, 2021
Convert ReactRelayPaginationContainer-test.js to use the new compiler
Summary: We're working on deprecating JS compiler. One of the steps, is to remove it from our unit-tests. This is the test from #3199 Steps: 1) Remove `generateAndCompile` 2) Wrap graphql documents with `graphql` tag + add unique prefix 3) Run new compiler: `scripts/compile-tests.sh` Reviewed By: tyao1 Differential Revision: D25874593 fbshipit-source-id: aa8b192cee0a4ad05b42e0153c19817f56b48ab3
1 parent 20051f6 commit bede32d

8 files changed

+1404
-30
lines changed
 

‎packages/react-relay/__tests__/ReactRelayPaginationContainer-test.js

+35-30
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ const ReactRelayPaginationContainer = require('../ReactRelayPaginationContainer'
1616
const ReactTestRenderer = require('react-test-renderer');
1717

1818
const {
19-
createReaderSelector,
20-
createOperationDescriptor,
2119
ConnectionHandler,
2220
ConnectionInterface,
21+
createOperationDescriptor,
22+
createReaderSelector,
23+
graphql,
2324
} = require('relay-runtime');
2425
const {
2526
createMockEnvironment,
26-
generateAndCompile,
2727
unwrapContainer,
2828
} = require('relay-test-utils-internal');
2929

@@ -89,8 +89,8 @@ describe('ReactRelayPaginationContainer', () => {
8989
environment = createMockEnvironment({
9090
handlerProvider: () => ConnectionHandler,
9191
});
92-
({UserFragment, UserQuery} = generateAndCompile(`
93-
query UserQuery(
92+
UserQuery = graphql`
93+
query ReactRelayPaginationContainerTestUserQuery(
9494
$after: ID
9595
$count: Int!
9696
$id: ID!
@@ -100,20 +100,23 @@ describe('ReactRelayPaginationContainer', () => {
100100
node(id: $id) {
101101
id
102102
__typename
103-
...UserFragment @arguments(isViewerFriendLocal: $isViewerFriend, orderby: $orderby)
103+
...ReactRelayPaginationContainerTestUserFragment
104+
@arguments(isViewerFriendLocal: $isViewerFriend, orderby: $orderby)
104105
}
105106
}
107+
`;
106108

107-
fragment UserFragment on User
109+
UserFragment = graphql`
110+
fragment ReactRelayPaginationContainerTestUserFragment on User
108111
@argumentDefinitions(
109112
isViewerFriendLocal: {type: "Boolean", defaultValue: false}
110113
orderby: {type: "[String]"}
111114
) {
112115
id
113116
friends(
114-
after: $after,
115-
first: $count,
116-
orderby: $orderby,
117+
after: $after
118+
first: $count
119+
orderby: $orderby
117120
isViewerFriend: $isViewerFriendLocal
118121
) @connection(key: "UserFragment_friends") {
119122
edges {
@@ -123,7 +126,7 @@ describe('ReactRelayPaginationContainer', () => {
123126
}
124127
}
125128
}
126-
`));
129+
`;
127130

128131
render = jest.fn(props => {
129132
({hasMore, isLoading, loadMore, refetchConnection} = props.relay);
@@ -747,20 +750,22 @@ describe('ReactRelayPaginationContainer', () => {
747750
});
748751

749752
it('fails if missing @connection directive', () => {
750-
({UserFragment, UserQuery} = generateAndCompile(`
751-
query UserQuery(
753+
UserQuery = graphql`
754+
query ReactRelayPaginationContainerTestNoConnectionUserQuery(
752755
$after: ID
753756
$count: Int!
754757
$id: ID!
755758
$orderby: [String]
756759
) {
757760
node(id: $id) {
758761
id
759-
...UserFragment
762+
...ReactRelayPaginationContainerTestNoConnectionUserFragment
760763
}
761764
}
765+
`;
762766

763-
fragment UserFragment on User {
767+
UserFragment = graphql`
768+
fragment ReactRelayPaginationContainerTestNoConnectionUserFragment on User {
764769
friends(after: $after, first: $count, orderby: $orderby) {
765770
edges {
766771
node {
@@ -773,8 +778,7 @@ describe('ReactRelayPaginationContainer', () => {
773778
}
774779
}
775780
}
776-
`));
777-
781+
`;
778782
expect(() => {
779783
ReactRelayPaginationContainer.createContainer(
780784
TestComponent,
@@ -798,33 +802,34 @@ describe('ReactRelayPaginationContainer', () => {
798802
});
799803

800804
it('does not fail invariant if one fragment has a @connection directive', () => {
801-
let ViewerFragment;
802-
({UserFragment, UserQuery, ViewerFragment} = generateAndCompile(`
803-
query UserQuery(
805+
UserQuery = graphql`
806+
query ReactRelayPaginationContainerTestNoConnectionOnFragmentUserQuery(
804807
$after: ID
805808
$count: Int!
806809
$id: ID!
807810
$orderby: [String]
808811
) {
809812
viewer {
810-
...ViewerFragment
813+
...ReactRelayPaginationContainerTestNoConnectionOnFragmentViewerFragment
811814
}
812815
node(id: $id) {
813816
id
814-
...UserFragment
817+
...ReactRelayPaginationContainerTestNoConnectionOnFragmentUserFragment
815818
}
816819
}
820+
`;
817821

818-
fragment ViewerFragment on Viewer {
819-
actor{
822+
const ViewerFragment = graphql`
823+
fragment ReactRelayPaginationContainerTestNoConnectionOnFragmentViewerFragment on Viewer {
824+
actor {
820825
id
821826
}
822827
}
823-
824-
fragment UserFragment on User {
825-
friends(after: $after, first: $count, orderby: $orderby) @connection(
826-
key: "UserFragment_friends"
827-
) {
828+
`;
829+
UserFragment = graphql`
830+
fragment ReactRelayPaginationContainerTestNoConnectionOnFragmentUserFragment on User {
831+
friends(after: $after, first: $count, orderby: $orderby)
832+
@connection(key: "UserFragment_friends") {
828833
edges {
829834
node {
830835
id
@@ -836,7 +841,7 @@ describe('ReactRelayPaginationContainer', () => {
836841
}
837842
}
838843
}
839-
`));
844+
`;
840845

841846
TestContainer = ReactRelayPaginationContainer.createContainer(
842847
TestComponent,

‎packages/react-relay/__tests__/__generated__/ReactRelayPaginationContainerTestNoConnectionOnFragmentUserFragment.graphql.js

+168
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/react-relay/__tests__/__generated__/ReactRelayPaginationContainerTestNoConnectionOnFragmentUserQuery.graphql.js

+292
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/react-relay/__tests__/__generated__/ReactRelayPaginationContainerTestNoConnectionOnFragmentViewerFragment.graphql.js

+69
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/react-relay/__tests__/__generated__/ReactRelayPaginationContainerTestNoConnectionUserFragment.graphql.js

+153
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/react-relay/__tests__/__generated__/ReactRelayPaginationContainerTestNoConnectionUserQuery.graphql.js

+227
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/react-relay/__tests__/__generated__/ReactRelayPaginationContainerTestUserFragment.graphql.js

+180
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/react-relay/__tests__/__generated__/ReactRelayPaginationContainerTestUserQuery.graphql.js

+280
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)
Please sign in to comment.