Do not create RuntimeExecutor on non-JSI executors #38125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47124234 |
Base commit: 3a912a3 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jun 30, 2023
Summary: Pull Request resolved: facebook#38125 On Android, when using the remote debugging feature (using legacy websockets), it's not safe to assume we can get a `jsi::Runtime` from `JSExecutor`. Changelog: [General][Fixed] Android does't crash when using remote debugger Reviewed By: NickGerleman Differential Revision: D47124234 fbshipit-source-id: b63d9eb5f1d7410f8150340dcd226e9317a2bfdc
javache
force-pushed
the
export-D47124234
branch
from
1e65f84
to
d5902a9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47124234 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D47124234 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jun 30, 2023
Summary: Pull Request resolved: facebook#38125 On Android, when using the remote debugging feature (using legacy websockets), it's not safe to assume we can get a `jsi::Runtime` from `JSExecutor`. Changelog: [General][Fixed] Android does't crash when using remote debugger Reviewed By: NickGerleman Differential Revision: D47124234 fbshipit-source-id: c178915af327604d12c48b1b472ad624a7b75e94
javache
force-pushed
the
export-D47124234
branch
from
d5902a9
to
3078097
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47124234 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Jun 30, 2023
Summary: Pull Request resolved: facebook#38125 On Android, when using the remote debugging feature (using legacy websockets), it's not safe to assume we can get a `jsi::Runtime` from `JSExecutor`. Changelog: [General][Fixed] Android does't crash when using remote debugger Reviewed By: NickGerleman Differential Revision: D47124234 fbshipit-source-id: 45ccc2544f104223efde1bec44e11b9cdfc1de52
javache
force-pushed
the
export-D47124234
branch
from
3078097
to
1dedc83
Compare
Summary: Pull Request resolved: facebook#38125 On Android, when using the remote debugging feature (using legacy websockets), it's not safe to assume we can get a `jsi::Runtime` from `JSExecutor`. Changelog: [General][Fixed] Android does't crash when using remote debugger Reviewed By: NickGerleman Differential Revision: D47124234 fbshipit-source-id: d6e93c760174361940d53fe8c2ebf4685d8cf8ae
|
This pull request was exported from Phabricator. Differential Revision: D47124234 |
javache
force-pushed
the
export-D47124234
branch
from
1dedc83
to
a34c48f
Compare
|
This pull request was successfully merged by @javache in 0fe5ffd. When will my fix make it into a release? | Upcoming Releases |
lunaleaps
pushed a commit
to lunaleaps/react-native
that referenced
this pull request
Jun 30, 2023
Summary: Pull Request resolved: facebook#38125 On Android, when using the remote debugging feature (using legacy websockets), it's not safe to assume we can get a `jsi::Runtime` from `JSExecutor`. Changelog: [General][Fixed] Android does't crash when using remote debugger Reviewed By: NickGerleman Differential Revision: D47124234 fbshipit-source-id: 0542da1aca5d411964e3a0833f4c48428ed90c91
AshlandWest
referenced
this pull request
in Salt-PepperEngineering/react-native-nordic-dfu
Jul 7, 2023
kelset
pushed a commit
that referenced
this pull request
Jul 10, 2023
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 11, 2023
…acebook#38142) Co-authored-by: Pieter De Baets <pieterdb@meta.com> resolved: facebook#38125
This was referenced Aug 1, 2023
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
On Android, when using the remote debugging feature (using legacy websockets), it's not safe to assume we can get a
jsi::RuntimefromJSExecutor.Changelog: [General][Fixed] Android does't crash when using remote debugger
Differential Revision: D47124234