Warn users when a component is registered in Rendere and in the interop #38089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47053556 |
Base commit: f7219ec |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 27, 2023
…op (facebook#38089) Summary: Pull Request resolved: facebook#38089 This change add a warning if a component is registered in both the New Renderer and in the Interop layer. This can help users migrating their components once the library has been migrated. ## Changelog: [iOS][Added] - Add warning to help users migrate away from the interop layer. Reviewed By: cortinico Differential Revision: D47053556 fbshipit-source-id: bc81168e8ee3a41a89c0a83b8862ac743d22ab99
cipolleschi
force-pushed
the
export-D47053556
branch
from
62e4c73
to
77e4907
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47053556 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 27, 2023
…op (facebook#38089) Summary: Pull Request resolved: facebook#38089 This change add a warning if a component is registered in both the New Renderer and in the Interop layer. This can help users migrating their components once the library has been migrated. ## Changelog: [iOS][Added] - Add warning to help users migrate away from the interop layer. Reviewed By: cortinico Differential Revision: D47053556 fbshipit-source-id: 0d0bdffd3892d1dd21227f47874fd8e13f88daac
cipolleschi
force-pushed
the
export-D47053556
branch
from
77e4907
to
2e712bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47053556 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jun 27, 2023
…op (facebook#38089) Summary: Pull Request resolved: facebook#38089 This change add a warning if a component is registered in both the New Renderer and in the Interop layer. This can help users migrating their components once the library has been migrated. ## Changelog: [iOS][Added] - Add warning to help users migrate away from the interop layer. Reviewed By: cortinico Differential Revision: D47053556 fbshipit-source-id: ba87b0aa51f9d7ffe0cb24c36533ddcd36b4d6c9
cipolleschi
force-pushed
the
export-D47053556
branch
from
2e712bf
to
722d95e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47053556 |
…op (facebook#38089) Summary: Pull Request resolved: facebook#38089 This change add a warning if a component is registered in both the New Renderer and in the Interop layer. This can help users migrating their components once the library has been migrated. ## Changelog: [iOS][Added] - Add warning to help users migrate away from the interop layer. Reviewed By: cortinico Differential Revision: D47053556 fbshipit-source-id: 782f57af5f6a9670b8b8fd6798c772e6b218ca98
|
This pull request was exported from Phabricator. Differential Revision: D47053556 |
cipolleschi
force-pushed
the
export-D47053556
branch
from
722d95e
to
a9ec867
Compare
|
This pull request was successfully merged by @cipolleschi in a702d05. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in a702d05. |
cipolleschi
added a commit
that referenced
this pull request
Jun 28, 2023
…op (#38089) Summary: Pull Request resolved: #38089 This change add a warning if a component is registered in both the New Renderer and in the Interop layer. This can help users migrating their components once the library has been migrated. [iOS][Added] - Add warning to help users migrate away from the interop layer. Reviewed By: cortinico Differential Revision: D47053556 fbshipit-source-id: cc2ba09db16aaa370947a77173b6ea6a0acfa519
Kudo
pushed a commit
to expo/react-native
that referenced
this pull request
Jul 3, 2023
…op (facebook#38089) Summary: Pull Request resolved: facebook#38089 This change add a warning if a component is registered in both the New Renderer and in the Interop layer. This can help users migrating their components once the library has been migrated. [iOS][Added] - Add warning to help users migrate away from the interop layer. Reviewed By: cortinico Differential Revision: D47053556 fbshipit-source-id: cc2ba09db16aaa370947a77173b6ea6a0acfa519
This was referenced Aug 10, 2023
This was referenced Jan 4, 2024
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change add a warning if a component is registered in both the New Renderer and in the Interop layer.
This can help users migrating their components once the library has been migrated.
Changelog:
[iOS][Added] - Add warning to help users migrate away from the interop layer.
Reviewed By: cortinico
Differential Revision: D47053556