pod install command doesn't update hermes pod
#36945
Comments
|
github-actions
bot
added
Needs: Author Feedback
Platform: iOS
|
This feels like a bug that we want to investigate on. cc @cipolleschi |
|
Came here to say the same. This is problematic in CI. Updating from 0.71.6 to 0.71.7 here's what we did: ...no mention of hermes-engine Then in CI we have a couple steps before a Fastlane build: Yet this error occurs: To resolve, we had to run |
|
Hi @jforaker, thanks for posting this. A quick question to understand better: when you run Was the app working? did this update the Because, if that's the case, perhaps you missed to update the Also, I see that you install |
Yes it was working. Everything except the Hermes portion got updated in Podfile.lock
@cipolleschi - not on purpose, I will revisit my CI steps as it’s been a long time since that was written. |
|
Hi there, Sorry for the late answer.
Well, then it means that pod install is actually updating Hermes and that the Podfile.lock should be pushed to CI, no? |
|
Hi, I can confirm this issue when upgrading from 0.71.2 to 0.71.7. Kind Regards |
@cipolleschi when run and when I do CocoaPods could not find compatible versions for pod "hermes-engine":
In snapshot (Podfile.lock):
hermes-engine (from `../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec`)
In Podfile:
hermes-engine (from `../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec`)
It seems like you've changed the version of the dependency `hermes-engine` and it differs from the version stored in `Pods/Local Podspecs`.
You should run `pod update hermes-engine --no-repo-update` to apply changes made locally.and when you check - FBReactNativeSpec (0.71.6): // the same that I have in package.json !!!
- hermes-engine (0.71.5) // <-- OLD VERSION |
github-actions
bot
added
Needs: Attention
|
Hi, we also had the issue when updating from 0.71.6 to 0.71.7. Here are the logs from our last build in appcenter. |
retyui
changed the title
pod install --project-directory ios command doesn't update hermes podpod install command doesn't update hermes pod
|
@retyui @kerembalcan Thank you for the detailed log. I hope to find some time to look into that. Probably, it could be reproduced easily by creating an app with 0.71.6 and upgrading it to 0.71.7. What do you guys usually do when updating a patch of an app? |
I do
|
|
@cipolleschi |
|
I just run a quick test: Then, I opened the },
"dependencies": {
"react": "18.2.0",
- "react-native": "0.71.6"
+ "react-native": "0.71.7"
},Then run again: And this is my
But effectively, the |
|
I think I found the problem. Here, we are defining that the Instead, by using
I'm setting up a PR to address this. |
Summary: This should fix facebook#36945, which is also causing annoyance when doing the releases ## Changelog: [iOS][Changed] - Use :path instead of :podspec to let cocoapods recognize Hermes updates Differential Revision: D45394241 fbshipit-source-id: 05f772f6033fe6c4215ffddb5601da3e8748b80a
|
so, is there a fixed release yet? Running into the same issue here after updating to |
|
There is a fix for 0.72, but we couldn't backport it to 0.71, unfortunately. :( This is the fix: 8de71e5 |
|
Thanks for sharing the fix! Considering that 0.72 isn't production-ready yet, what is the remedy in the meanwhile? |
|
The remedy so far would be to run We are looking into backporting the fix also to 0.70 and 0.71 at least, but we don't have a patch release scheduled yet for those versions, unfortunately. |
|
fixed |
is it fixed in 0.72... any update ? |
|
Yes 8de71e5 has been shipped to 0.72. |
|
This is still an issue I encountered when upgrading to 0.72.1 and 0.72.2 🙃 |
|
That's expected. Are you encountering issues while working on the app? |
github-actions
bot
added
the
Needs: Repro
|
So every upgrade we will need to run |
So... you are encountering a problem! :D No, this should not happen! thank you for signalling this. I'll put it in my queue and I hope to find a solution before the next release. |
|
Apologies if it came off as rude, I thought you meant more if it was affecting any other part of the development workflow. Thanks for looking into it :) |
|
I experienced this from 0.71.8-> 0.72.5. The previously solution of |
|
I'm seeing it, too – am I correct in understanding that the fix in |
|
I'm facing this issue in react-native in version 0.72.7 any updates..? |
|
in my case, in circle ci remain cache data. i just run cache clean and build, it's fixed |
|
I've been going around in circles with this and not been able to install Hermes Engine at all - does anyone have something like this going on? It keeps finding another copy of hermes and refusing to carry on: CommandStackPluginsPodfilerequire File.join(File.dirname(`node --print "require.resolve('expo/package.json')"`), "scripts/autolinking")
require File.join(File.dirname(`node --print "require.resolve('react-native/package.json')"`), "scripts/react_native_pods")
require_relative '../node_modules/react-native-permissions/scripts/setup'
require 'json'
podfile_properties = JSON.parse(File.read(File.join(__dir__, 'Podfile.properties.json'))) rescue {}
ENV['RCT_NEW_ARCH_ENABLED'] = podfile_properties['newArchEnabled'] == 'true' ? '1' : '0'
ENV['EX_DEV_CLIENT_NETWORK_INSPECTOR'] = podfile_properties['EX_DEV_CLIENT_NETWORK_INSPECTOR']
platform :ios, podfile_properties['ios.deploymentTarget'] || '13.4'
install! 'cocoapods',
:deterministic_uuids => false
prepare_react_native_project!
# If you are using a `react-native-flipper` your iOS build will fail when `NO_FLIPPER=1` is set.
# because `react-native-flipper` depends on (FlipperKit,...), which will be excluded. To fix this,
# you can also exclude `react-native-flipper` in `react-native.config.js`
#
# ```js
# module.exports = {
# dependencies: {
# ...(process.env.NO_FLIPPER ? { 'react-native-flipper': { platforms: { ios: null } } } : {}),
# }
# }
# ```
flipper_config = FlipperConfiguration.disabled
if ENV['NO_FLIPPER'] == '1' then
# Explicitly disabled through environment variables
flipper_config = FlipperConfiguration.disabled
elsif podfile_properties.key?('ios.flipper') then
# Configure Flipper in Podfile.properties.json
if podfile_properties['ios.flipper'] == 'true' then
flipper_config = FlipperConfiguration.enabled(["Debug", "Release"])
elsif podfile_properties['ios.flipper'] != 'false' then
flipper_config = FlipperConfiguration.enabled(["Debug", "Release"], { 'Flipper' => podfile_properties['ios.flipper'] })
end
end
target 'InTune' do
use_expo_modules!
config = use_native_modules!
use_frameworks! :linkage => podfile_properties['ios.useFrameworks'].to_sym if podfile_properties['ios.useFrameworks']
use_frameworks! :linkage => ENV['USE_FRAMEWORKS'].to_sym if ENV['USE_FRAMEWORKS']
use_react_native!(
:path => config[:reactNativePath],
:hermes_enabled => podfile_properties['expo.jsEngine'] == nil || podfile_properties['expo.jsEngine'] == 'hermes',
# An absolute path to your application root.
:app_path => "#{Pod::Config.instance.installation_root}/..",
# Note that if you have use_frameworks! enabled, Flipper will not work if enabled
:flipper_configuration => flipper_config
)
post_install do |installer|
react_native_post_install(
installer,
config[:reactNativePath],
:mac_catalyst_enabled => false
)
# This is necessary for Xcode 14, because it signs resource bundles by default
# when building for devices.
installer.target_installation_results.pod_target_installation_results
.each do |pod_name, target_installation_result|
target_installation_result.resource_bundle_targets.each do |resource_bundle_target|
resource_bundle_target.build_configurations.each do |config|
config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO'
end
end
end
end
post_integrate do |installer|
begin
expo_patch_react_imports!(installer)
rescue => e
Pod::UI.warn e
end
end
end
setup_permissions([
'Microphone'
])Error |
|
This is a known issue that manifested earlier today because Cocoapods released version 1.15 which is breaking. Please refer to #42698 for updates. The workaround for the time being is to downgrade to Cocoapods 1.14. |
Description
When you update React Native version and then do
pod installornpx pod-installit won't update Hermestested on react native: 0.70.8,0.71.6
React Native Version
0.71.6
Output of
npx react-native infoSteps to reproduce
Result
ios/Podfil.lockSnack, code example, screenshot, or link to a repository
...
The text was updated successfully, but these errors were encountered: