Fix animating background colors in View (#47101)

joevilches · facebook-github-bot · commit 1d6ac0953014 · 2024-10-17T11:58:12.000-07:00
Summary: Pull Request resolved: #47101 See #47011 borders do not have this problem because they call `removeAllAnimations` on the layer after changing it, which is what I am doing here Changelog: [iOS] [fixed] - Fixed bug where background colors would sometimes animate when changing on Views Reviewed By: cipolleschi Differential Revision: D64493968 fbshipit-source-id: cf81549f21b124b67c6e7647c6ae827bfe80a9cf
diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm b/packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
@@ -894,6 +894,8 @@ - (void)invalidateLayer
       _backgroundColorLayer.mask = maskLayer;
       _backgroundColorLayer.cornerRadius = 0;
     }
+
+    [_backgroundColorLayer removeAllAnimations];
   }
 
   // borders

Original file line number	Diff line number	Diff line change
`@@ -894,6 +894,8 @@ - (void)invalidateLayer`
`894`	`894`	`_backgroundColorLayer.mask = maskLayer;`
`895`	`895`	`_backgroundColorLayer.cornerRadius = 0;`
`896`	`896`	`}`
	`897`	`+`
	`898`	`+ [_backgroundColorLayer removeAllAnimations];`
`897`	`899`	`}`
`898`	`900`
`899`	`901`	`// borders`