Fix missing dependency on metro-transform-worker
#817
Closed
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
Currently, `metro-config` calls `require.resolve('metro-transform-worker')` to establish the default value for `transformerPath`. However, `metro-config` doesn't list `metro-transform-worker` as a dependency, so this fails when `metro-config` is used as a standalone package.
It isn't strictly necessary for this value to be an an absolute path in the current implementation - it just needs to be `require`-able from within `metro` (specifically [`DeltaBundler/Worker.js`](https://github.com/facebook/metro/blob/347b1d7ed87995d7951aaa9fd597c04b06013dac/packages/metro/src/DeltaBundler/Worker.js#L61-L64)).
This diff documents that `transformerPath` may be a package name, and changes to the default config to just use the default package name `metro-transform-worker`, removing the dependency.
Fixes facebook#805
Differential Revision: D36208763
fbshipit-source-id: 096c85f6aa10d7ed64eb7059dcab377de270f3a9
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D36208763 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently,
metro-configcallsrequire.resolve('metro-transform-worker')to establish the default value fortransformerPath. However,metro-configdoesn't listmetro-transform-workeras a dependency, so this fails whenmetro-configis used as a standalone package.It isn't strictly necessary for this value to be an an absolute path in the current implementation - it just needs to be
require-able from withinmetro(specificallyDeltaBundler/Worker.js).This diff documents that
transformerPathmay be a package name, and changes to the default config to just use the default package namemetro-transform-worker, removing the dependency.Fixes #805
Differential Revision: D36208763