Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ariaErrorMessage and ariaInvalid to Flow type #6751

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ejhammond
Copy link
Contributor

@ejhammond ejhammond commented Oct 21, 2024

In #6745 I added aria-errormessage and aria-invalid to the Flow type but I forgot to add ariaErrorMessage and ariaInvalid.

This diff adds those two props so that the Flow and TS types are equivalent again.

The runtime impl already handles these props.

Verified

This commit was signed with the committer’s verified signature.
crazy-max CrazyMax
Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 3:23pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 3:23pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2024
Copy link

size-limit report 📦

Path Size
lexical - cjs 29.94 KB (0%)
lexical - esm 29.78 KB (0%)
@lexical/rich-text - cjs 38.51 KB (0%)
@lexical/rich-text - esm 31.58 KB (0%)
@lexical/plain-text - cjs 37.16 KB (0%)
@lexical/plain-text - esm 29 KB (0%)
@lexical/react - cjs 40.29 KB (0%)
@lexical/react - esm 33 KB (0%)

@ejhammond ejhammond added this pull request to the merge queue Oct 21, 2024
Merged via the queue into facebook:main with commit 1b4f1e0 Oct 21, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants