Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-playground] Fix: in playground show component-menu when scroll #6510

Merged

Conversation

keiseiTi
Copy link
Contributor

Description

in playground show component-menu when scroll

Test plan

Before

iShot_2024-08-10_15 19 16

After

iShot_2024-08-10_15 27 15

Copy link

vercel bot commented Aug 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 5:20pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 5:20pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 10, 2024
Copy link

github-actions bot commented Aug 10, 2024

size-limit report 📦

Path Size
lexical - cjs 29.38 KB (0%)
lexical - esm 29.24 KB (0%)
@lexical/rich-text - cjs 37.74 KB (0%)
@lexical/rich-text - esm 31.05 KB (0%)
@lexical/plain-text - cjs 36.41 KB (0%)
@lexical/plain-text - esm 28.42 KB (0%)
@lexical/react - cjs 39.64 KB (0%)
@lexical/react - esm 32.51 KB (0%)

@ivailop7
Copy link
Collaborator

This is essentially undoing: #5859

In the preview for this PR, you can reproduce the issue YOffset was fixing, if you do a very long text, scroll down and do / for the menu to show up, it's rendered incorrectly offscreen. This logic is also used by the Lexical context menu, which you essential fix this for correctly, but break the typeahead when triggered at a lower scrolled page position.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work great for me, I am unable to reproduce any positioning issues with the menu in the scenarios I could find

@etrepum etrepum added this pull request to the merge queue Aug 22, 2024
Merged via the queue into facebook:main with commit fd7a93d Aug 22, 2024
43 checks passed
zurfyx added a commit that referenced this pull request Aug 26, 2024
…hen scroll (#6510)"

This reverts commit fd7a93d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants