[lexical] [lexical-selection] Preserve paragraph styles between lines #6437
+138
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
ivailop7
changed the title
size-limit report 📦
|
ivailop7
changed the title
ivailop7
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
Sahejkm and
potatowagon
as code owners
ivailop7
changed the title
ivailop7
force-pushed
the
preserve_styles
branch
from
d55df81 to
a4d52b8
Compare
ivailop7
force-pushed
the
preserve_styles
branch
from
a4d52b8 to
8f81c8e
Compare
zurfyx
approved these changes
Jul 22, 2024
|
You should be careful of making getStyle and setStyle methods on LexicalElementNode. This can cause conflicts for users who want to upgrade their lexical dependency when they are extending nodes to support importing inline style to them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug where we don't preserve style attributes like color, font size, background color or any custom styles when creating a new paragraph (press Enter twice).
Heavily inspired by the solution for the formatting: #5822
I've just extended in the same fashion for the styling.
Closes #5958
Before:
before_styling.mov
After:
after_styling.mov