Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lexical][Tables] Follow up on #6267 handle multi column delete crash on forward selection at end of the table #6279

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented Jun 9, 2024

What

fix crash on forward column deletion at the end of the table

Why

currently backward multiple column deletion at the end of the table works, forward multiple column deletion crashes, add handling for the same.

Before

Screen.Recording.2024-06-09.at.1.47.39.PM.mov

After

Screen.Recording.2024-06-09.at.1.47.20.PM.mov

…ion at end of the table
Copy link

vercel bot commented Jun 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 5:49am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 5:49am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2024
Copy link

github-actions bot commented Jun 9, 2024

size-limit report 📦

Path Size
lexical - cjs 28.31 KB (0%)
lexical - esm 28.13 KB (0%)
@lexical/rich-text - cjs 36.77 KB (0%)
@lexical/rich-text - esm 28.09 KB (0%)
@lexical/plain-text - cjs 35.36 KB (0%)
@lexical/plain-text - esm 25.33 KB (0%)
@lexical/react - cjs 38.51 KB (0%)
@lexical/react - esm 29.14 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants