Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lexical][CI] Skip extended tests workflow run on multiple approvals #6265

Merged
merged 12 commits into from
Jun 7, 2024
Merged

[Lexical][CI] Skip extended tests workflow run on multiple approvals #6265

merged 12 commits into from
Jun 7, 2024
+30 −4

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented Jun 7, 2024 •
edited
Loading

WHAT

Followup on #6198 , to skip extended tests workflow run on multiple approvals

WHY

Running e2e tests twice on approved PRs doesn't make sense and add to the overal CI cost, hence skip duplicate workflow run

Sahejkm added 3 commits June 7, 2024 11:30
@Sahejkm
[Testing][Lexical] Skip extended tests workflow on multiple approvals
Loading
Loading status checks…
d86825d
@Sahejkm
add skip check condition

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
bd39078
@Sahejkm
test only diff
Loading
Loading status checks…
0d33d03
@vercel Vercel
Copy link

vercel bot commented Jun 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 9:18am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 9:18am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 28.33 KB (0%)
lexical - esm 28.14 KB (0%)
@lexical/rich-text - cjs 36.75 KB (0%)
@lexical/rich-text - esm 28.09 KB (0%)
@lexical/plain-text - cjs 35.33 KB (0%)
@lexical/plain-text - esm 25.31 KB (0%)
@lexical/react - cjs 38.54 KB (0%)
@lexical/react - esm 29.17 KB (0%)

Sahejkm
Sahejkm commented Jun 7, 2024
View reviewed changes
Copy link
Contributor Author

@Sahejkm Sahejkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test1

Sahejkm
Sahejkm commented Jun 7, 2024
View reviewed changes
Copy link
Contributor Author

@Sahejkm Sahejkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test2

Sahejkm added 2 commits June 7, 2024 14:44
@Sahejkm
test only diff

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
fbaeb4f
@Sahejkm
Merge branch 'skip_extended_multiple_approvals' of https://github.com…
Loading
Loading status checks…
be09932 
…/facebook/lexical into skip_extended_multiple_approvals
Sahejkm
Sahejkm commented Jun 7, 2024
View reviewed changes
Copy link
Contributor Author

@Sahejkm Sahejkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test3

@Sahejkm
add logging

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
ed6c186
Sahejkm
Sahejkm commented Jun 7, 2024
View reviewed changes
Copy link
Contributor Author

@Sahejkm Sahejkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test1

@Sahejkm
add logging
Loading
Loading status checks…
3e8d951
Sahejkm
Sahejkm commented Jun 7, 2024
View reviewed changes
Copy link
Contributor Author

@Sahejkm Sahejkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@Sahejkm
fix conditional
Loading
Loading status checks…
9dbbe76
Sahejkm
Sahejkm commented Jun 7, 2024
View reviewed changes
Copy link
Contributor Author

@Sahejkm Sahejkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@Sahejkm
test
Loading
Loading status checks…
ae41144
Sahejkm
Sahejkm commented Jun 7, 2024
View reviewed changes
Copy link
Contributor Author

@Sahejkm Sahejkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment 1

Sahejkm
Sahejkm commented Jun 7, 2024
View reviewed changes
Copy link
Contributor Author

@Sahejkm Sahejkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment 2

@Sahejkm
revert on commented code for testing
Loading
Loading status checks…
c56fc81
@Sahejkm Sahejkm changed the title Skip extended multiple approvals [Lexical][CI] Skip extended tests workflow run on multiple approvals Jun 7, 2024
@Sahejkm Sahejkm marked this pull request as ready for review June 7, 2024 07:44
@Sahejkm
add paths-ignore
Loading
Loading status checks…
f7ef8c3
potatowagon
potatowagon approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@potatowagon potatowagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sahejkm Sahejkm added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit 92bee5d Jun 7, 2024
39 checks passed
This was referenced Jul 23, 2024
Open
Open
@zurfyx zurfyx deleted the skip_extended_multiple_approvals branch February 28, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potatowagon potatowagon

@zurfyx zurfyx

@fantactuka fantactuka

@acywatson acywatson

@Fetz Fetz

@ivailop7 ivailop7

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sahejkm @potatowagon @facebook-github-bot