[lexical-playground] CI: fix flaky collab test #6240
Conversation
potatowagon
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7 and
Sahejkm
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
potatowagon
changed the title
potatowagon
changed the title
| @@ -99,6 +99,25 @@ test.describe('Toolbar', () => { | |||
| ignoreClasses: true, | |||
| ignoreInlineStyles: true, | |||
| }, | |||
| (actualHtml) => | |||
| // flaky fix: remove the extra <p><br /></p> that appears occasionally in CI runs | |||
There was a problem hiding this comment.
do we want to add a check for collab if flakyness is for collab mode only ?
There was a problem hiding this comment.
afaik these extra chars only appear for collab, tho if it happens to appear for non collab, no harm helping to remove the xtra chars so the test is not flaky
|
i think we don't need to add label if the PR is approved ald, it cancelled the run https://github.com/facebook/lexical/actions/runs/9346276629/usage and restarted a new one :( |
sorry, perhaps i forgot to refresh the page, i added the tag when i saw the e2e tests were skipped |
Description
https://github.com/facebook/lexical/actions/runs/9294132717/job/25578693971?pr=6201
^ this e2e collab test fails occasionally on the CI due to flakiness. the output is an extra
<p></br><p>add a callback to modify actual html. this callback is useful to adjust for flaky html outputs
Closes #6241
Test plan
✓ 1 [chromium] › packages/lexical-playground/tests/e2e/Toolbar.spec.mjs:37:8 › Toolbar › Insert image caption + table (2.5s)