[*] Fix: Resolve Windows regression caused by upgrading glob #6227
+35
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
etrepum
force-pushed
the
debug-windows-e2e
branch
from
9a45472 to
2b27e60
Compare
etrepum
force-pushed
the
debug-windows-e2e
branch
from
2b27e60 to
4448650
Compare
etrepum
force-pushed
the
debug-windows-e2e
branch
from
4448650 to
d6b572a
Compare
etrepum
force-pushed
the
debug-windows-e2e
branch
from
d6b572a to
47f84da
Compare
etrepum
force-pushed
the
debug-windows-e2e
branch
from
47f84da to
6ce79ff
Compare
etrepum
force-pushed
the
debug-windows-e2e
branch
from
6ce79ff to
7289332
Compare
etrepum
changed the title
etrepum
requested review from
zurfyx,
fantactuka,
acywatson and
Fetz
as code owners
StyleT
previously approved these changes
May 31, 2024
|
I believe that the only remaining test failures will be fixed by #6228, the glob related issues should be solved |
StyleT
approved these changes
May 31, 2024
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading glob in #6215 changed its behavior on Windows, since it now expects you to specify paths that use '/' as the path separator so that '\' can be used for escaping glob characters unless the windowsPathsNoEscape option is specified which disables escaping of glob characters (a feature we do not use).
Hopefully #6198 works and lands soon so that this type of regression can be avoided in the future
Test Plan
Please add the extended-tests label to this PR so that we can confirm that it works before merging
Before
Windows e2e tests failed
After
Windows e2e tests should succeed