Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the label-on-approval workflow #6136

Merged
merged 1 commit into from
May 19, 2024
Merged

Fix the label-on-approval workflow #6136

merged 1 commit into from
May 19, 2024
+32 −24

Conversation

necolas
Copy link
Contributor

@necolas necolas commented May 18, 2024

Resolves issues with #6120 (probably)

@vercel Vercel
Copy link

vercel bot commented May 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 4:40pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 4:40pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 18, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.91 KB (0%) 479 ms (0%) 116 ms (+11.58% 🔺) 594 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.6 KB (0%) 693 ms (0%) 217 ms (-15.21% 🔽) 909 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 34.51 KB (0%) 691 ms (0%) 298 ms (+8.24% 🔺) 988 ms

@Sahejkm
Copy link
Contributor

Sahejkm commented May 18, 2024 •
edited
Loading

  • I don't think this works and auto triggers e2e tests, 1 GitHub workflow can't trigger another GitHub workflow as per the docs unless we use a pat token to run add label job.

  • 6120 is working fine for meta employees but not for external reviews becoz the GitHub actions don't have permissions for fork PRs and need pull request target event to work

@necolas necolas force-pushed the fix-label-approval-workflow branch from 77da31a to 9e8aae6 Compare May 18, 2024 14:53
@necolas
Copy link
Contributor Author

necolas commented May 18, 2024

Got it. Updated to rename jobs for clarity (since it's less about labels and more about what happens after approval), and adopted the alternative trigger that you said would work for PRs from forks

Sahejkm
Sahejkm previously approved these changes May 18, 2024
View reviewed changes
@Sahejkm
Copy link
Contributor

Sahejkm commented May 18, 2024

  • I think it broke :( , I will test and create a pr for this as it was ald on my mind 😀

  • we have to give both pull request and pull request target

  • we should specify branch also when using pull request target

@necolas
Fix the label-on-approval workflow

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
9beca5d
@necolas necolas force-pushed the fix-label-approval-workflow branch from 9e8aae6 to 9beca5d Compare May 18, 2024 16:39
@necolas
Copy link
Contributor Author

necolas commented May 18, 2024

Updated

necolas
necolas commented May 18, 2024
View reviewed changes
Copy link
Contributor Author

@necolas necolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test review

Sahejkm
Sahejkm approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@Sahejkm Sahejkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @necolas for enhancing this!

@github-actions github-actions bot added the extended-tests Run extended e2e tests on a PR label May 19, 2024
@Sahejkm Sahejkm added this pull request to the merge queue May 19, 2024
Merged via the queue into main with commit 58853cc May 19, 2024
51 checks passed
@etrepum etrepum mentioned this pull request May 20, 2024
Merged
@Sahejkm Sahejkm mentioned this pull request May 21, 2024
Merged
This was referenced Jun 26, 2024
Open
Open
@zurfyx zurfyx deleted the fix-label-approval-workflow branch February 28, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sahejkm Sahejkm

@zurfyx zurfyx

@fantactuka fantactuka

@acywatson acywatson

@Fetz Fetz

@ivailop7 ivailop7

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@necolas @Sahejkm @facebook-github-bot