Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing --coverageDirectory documentation #13932

Merged
merged 1 commit into from Feb 18, 2023
Merged

Conversation

frosas
Copy link
Contributor

@frosas frosas commented Feb 17, 2023

Summary

Jest CLI supports that option but it's not currently documented.

Test plan

N/A

@facebook-github-bot
Copy link
Contributor

Hi @frosas!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@frosas frosas changed the title Add missing --coverageDirectory Add missing --coverageDirectory documentation Feb 17, 2023
@frosas
Copy link
Contributor Author

frosas commented Feb 17, 2023

I guess at least https://github.com/facebook/jest/blob/main/docs/CLI.md will need to be updated too but I'll let you confirm it first.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@mrazauskas
Copy link
Contributor

Thanks. Good idea to add it.

I guess at least https://github.com/facebook/jest/blob/main/docs/CLI.md will need to be updated too but I'll let you confirm it first.

That’s right. This and all versioned docs should be updated as well, because this flag was added at least before Jest 20.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

6 similar comments
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Feb 18, 2023

closing and reopening to make bot less noisy

@SimenB SimenB closed this Feb 18, 2023
@SimenB SimenB reopened this Feb 18, 2023
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@frosas
Copy link
Contributor Author

frosas commented Feb 18, 2023

@mrazauskas done. It was introduced in v19 https://github.com/facebook/jest/blob/d8e29382c9cb83f6f7a712c9dc2835b69a81e5f5/CHANGELOG.md?plain=1#L3135 so I updated all the available documentation versions.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 1eb3bb5 into jestjs:main Feb 18, 2023
@frosas frosas deleted the patch-1 branch February 18, 2023 14:51
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants