Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What should be included in v0.7.1 #384

Closed
Huxpro opened this issue Oct 8, 2020 · 6 comments
Closed

What should be included in v0.7.1 #384

Huxpro opened this issue Oct 8, 2020 · 6 comments
Assignees
@Huxpro
Labels
release

Comments

@Huxpro
Copy link
Contributor

Huxpro commented Oct 8, 2020 •
edited

This issue is to record which commits need to be backported to support the patch release v0.7.1 for facebook/react-native#29914
@Huxpro Huxpro self-assigned this Oct 8, 2020
@Huxpro
Copy link
Contributor Author

Huxpro commented Oct 8, 2020 •
edited

Sorted in order:

#363

#365

#364

#354

#376 (helpd with #368)

Noted that v0.7.0 was tagged upon 508f92c so #352 had already been included and we'll branch out from that.

@Huxpro
Copy link
Contributor Author

Huxpro commented Oct 8, 2020

Hit merge conflicts on .circleci/config.yml when merging 67e644d, realized there was an intermediate commit from #355. Aborted and cherry-picked 2e63cf7 first.

@Huxpro
Copy link
Contributor Author

Huxpro commented Oct 9, 2020

Cherry-picked #385 to 0.7 branch and updated the tag v0.7.1.
After CircleCI is done we can finally publish to CocoaPod.

@Huxpro
Copy link
Contributor Author

Huxpro commented Oct 23, 2020 •
edited

Cherry-picked #393. Let's see if CircleCI is happy about it.

TODO (if success)

  • replace the apple related artifacts in the github release.
  • publish the new artifacts to CocoaPod with the github release http url. it's the same url!!

@Huxpro
Copy link
Contributor Author

Huxpro commented Oct 23, 2020 •
edited

Cherry-picked #396.
Waiting for the CircleCI jobs then we can "hot reload" the github release again.

@Huxpro
Copy link
Contributor Author

Huxpro commented Dec 8, 2020 •
edited

Cherry-picked the memory profiler patches #399 mentioned in facebook/react-native#29914 and hot reload the github release again.

Closed and considered frozen since the RN 0.64-rc1 release has already shipped with 0.7.1 release.

Noted that

  • The "hot reload Cocoapod" approach by replacing github release artifact is an extremely temporary workaround simply to unblock RN 0.64 rc-1 cut.
  • Also, hermes-engine 0.7.1 npm packages (used by Android) were actually published before this patch (hence the v0.7.1 tag was pointing to Rename and conditionalize source for podspec #385) so technically memory profiler should be broken there.
    • However, it was less an issue since iOS build was a compilation error and the Android build seem to be just UB when the out-of-sync API was called.

However since it's RN pre-release and we're doing another release. I'm not bothering fixing the already out 0.7.1.

@Huxpro Huxpro closed this as completed Dec 8, 2020
@Huxpro Huxpro mentioned this issue Dec 8, 2020
Closed
@Huxpro Huxpro added the release label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Huxpro Huxpro

Labels
release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Huxpro