Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/flipper
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.260.0
Choose a base ref
...
head repository: facebook/flipper
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.261.0
Choose a head ref
  • 8 commits
  • 18 files changed
  • 6 contributors

Commits on Jul 26, 2024

  1. Flipper Snapshot Bump: v0.260.1-SNAPSHOT

    Summary: Releasing snapshot version 0.260.1-SNAPSHOT
    
    Reviewed By: LukeDefeo
    
    Differential Revision: D60290527
    
    fbshipit-source-id: 204c671de38a38f58f0e5ddfbed7f1b7efb06a25
    generatedunixname89002005306973 authored and facebook-github-bot committed Jul 26, 2024
    Copy the full SHA
    c0bd55e View commit details

Commits on Jul 29, 2024

  1. Skip hanging tests (#5662)

    Summary:
    A couple of tests have open handlers that cause jest to timeout in GitHub actions. Skipping these should fix the step to allow other jobs to run
    
    Example failure
    
    https://github.com/facebook/flipper/actions/runs/10083622244/job/27880598756#step:8:762
    
    Pull Request resolved: #5662
    
    Test Plan:
    macos-latest jobs no longer fail on GitHub actions
     {F1780444328}
    
    Reviewed By: passy
    
    Differential Revision: D60389465
    
    Pulled By: antonk52
    
    fbshipit-source-id: e232a9a1f5f46b61fec334c0e312b70b1c9ca0ba
    antonk52 authored and facebook-github-bot committed Jul 29, 2024
    Copy the full SHA
    5f4f25f View commit details
  2. Don't Store Image Response bodies for Network and Network Chart plugi…

    …n if there is no flipper connection
    
    Summary:
    Context
    =
    I am creating a flipper plugin to track and show network requests in a waterfall display to help IG App developers
    
    See this [GSD](https://www.internalfb.com/gsd/316319693088236/791974585995443/list?t=189784262) for more context
    
    This Diff
    =
    As the title indicates, this diff strips response bodies if there's no flipper connection in Network and IGNetworkingBehavior plugins. This is to reduce the amount of memory used by the plugin and prevent OOM issues for debug builds for developers not using flipper.
    
    Reviewed By: pfarcasanu
    
    Differential Revision: D60175106
    
    fbshipit-source-id: 07d1895b6da15fdca70719606f4ef46ef0b02688
    Kareem Trevor DaCosta authored and facebook-github-bot committed Jul 29, 2024
    Copy the full SHA
    b9b25e2 View commit details

Commits on Jul 30, 2024

  1. install plugins dependencies in parallel

    Reviewed By: LukeDefeo
    
    Differential Revision: D60448300
    
    fbshipit-source-id: de74665981cafaa40d8531857ee67adee41d3a84
    antonk52 authored and facebook-github-bot committed Jul 30, 2024
    Copy the full SHA
    1a59aca View commit details

Commits on Jul 31, 2024

  1. Interngraph server error class

    Summary: We were losing the request body which meant that a clear request code could not be used, by adding an error subclass we can check for it in catch clause
    
    Reviewed By: passy
    
    Differential Revision: D59961466
    
    fbshipit-source-id: 490e831759d90d4e83153daf4b7a4baa5b38dbdb
    Luke De Feo authored and facebook-github-bot committed Jul 31, 2024
    Copy the full SHA
    7143c79 View commit details
  2. Update ApplicationWrapper param that received null value to Nullable

    Summary:
    Runtime plugin showed null savedInstanceState passed into onActivityCreated.
    
    ## Context
    We are in the process of making the entire codebase Nullsafe. This diff relies on a runtime codemod to track when null is passed into a parameter that is not marked as Nullable in java. Based on runtime data, we can be 100% certain that this parameter needs to be Nullable
    
    Reviewed By: jocelynluizzi13
    
    Differential Revision: D60469755
    
    fbshipit-source-id: 2d4385326bff7c4f75c1c26afd2552d2be4fa42b
    Philip Corriveau authored and facebook-github-bot committed Jul 31, 2024
    Copy the full SHA
    0f76111 View commit details
  3. Remove unused exception parameter from xplat/safe_image/io/ImageInfo.cpp

    Summary:
    `-Wunused-exception-parameter` has identified an unused exception parameter. This diff removes it.
    
    This:
    ```
    try {
        ...
    } catch (exception& e) {
        // no use of e
    }
    ```
    should instead be written as
    ```
    } catch (exception&) {
    ```
    
    If the code compiles, this is safe to land.
    
    Reviewed By: dmm-fb
    
    Differential Revision: D60516143
    
    fbshipit-source-id: 14f13290af21103d1c1ad38d708817376b3d6681
    r-barnes authored and facebook-github-bot committed Jul 31, 2024
    Copy the full SHA
    cd3abd5 View commit details

Commits on Aug 1, 2024

  1. Flipper Release: v0.261.0

    Summary: Releasing version 0.261.0
    
    Reviewed By: LukeDefeo
    
    Differential Revision: D60507277
    
    fbshipit-source-id: ca146d0f2ce16e4989ca3bf399622fe3149c105f
    generatedunixname89002005306973 authored and facebook-github-bot committed Aug 1, 2024
    Copy the full SHA
    6db3f04 View commit details
Loading