Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar results link and SearchPage don't load new results after first view #8755

Closed
6 of 7 tasks
dtlhlbs opened this issue Mar 9, 2023 · 1 comment · Fixed by #8757
Closed
6 of 7 tasks

Search bar results link and SearchPage don't load new results after first view #8755

dtlhlbs opened this issue Mar 9, 2023 · 1 comment · Fixed by #8757
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@dtlhlbs
Copy link

dtlhlbs commented Mar 9, 2023

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

The See all n results link at the bottom of the search modal from the search bar doesn't load new search results if the SearchPage is already loaded.

Reproducible demo

No response

Steps to reproduce

  1. Go to https://docusaurus.io/
  2. Search for "Admonition" using search bar
  3. Scroll to bottom of modal to the See all n results link
  4. Select results link and view all results
  5. Open the search bar on the top right and search for "Blog"
  6. Scroll to bottom of modal to the See all n results link
  7. Select results link and view all results

Expected behavior

URL changes to https://docusaurus.io/search?q=blog
Results for "Blog" would be displayed on the search results page

Actual behavior

URL changes to https://docusaurus.io/search?q=blog
Results for "Admonition" are still displayed

Your environment

https://docusaurus.io

Self-service

  • I'd be willing to fix this bug myself.
@slorber
Copy link
Collaborator

slorber commented Mar 10, 2023

Thanks, will be fixed in #8757

@slorber slorber removed the status: needs triage This issue has not been triaged by maintainers label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants