Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LeaderElector doesn't call onStopLeading #5463

Closed
shawkins opened this issue Sep 19, 2023 · 0 comments · Fixed by #5464
Closed

LeaderElector doesn't call onStopLeading #5463

shawkins opened this issue Sep 19, 2023 · 0 comments · Fixed by #5464
Assignees
@shawkins
Labels
bug
Milestone
6.9.0

Comments

@shawkins
Copy link
Contributor

See operator-framework/java-operator-sdk#2056

If releaseOnCancel is true and the current leader is in the process of loosing the lease, then the final release call will skip calling onStopLeading.
@shawkins shawkins changed the title LeaderElector doesn't call onStop LeaderElector doesn't call onStopLeading Sep 19, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Sep 19, 2023
@shawkins
fix: ensure that onStopLeading is called
13dbd22 
closes fabric8io#5463
@manusa manusa added the bug label Sep 19, 2023
@manusa manusa added this to the 6.9.0 milestone Sep 19, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Sep 19, 2023
@shawkins
fix: ensure that onStopLeading is called
057fdbd 
closes fabric8io#5463
@shawkins shawkins mentioned this issue Sep 19, 2023
Merged
11 tasks
manusa pushed a commit that referenced this issue Sep 19, 2023
@shawkins @manusa
fix: ensure that onStopLeading is called
0f6c696 
closes #5463
@XComp XComp mentioned this issue Jan 26, 2024
Merged
XComp added a commit to XComp/flink that referenced this issue Jan 29, 2024
@XComp
[FLINK-34007][k8s] Upgrade k8s client to v6.9.0 to cover client issue a…
3855035 
…pache#5464

fabric8io/kubernetes-client#5463
XComp added a commit to XComp/flink that referenced this issue Jan 29, 2024
@XComp
[FLINK-34007][k8s] Upgrade k8s client to v6.9.0 to cover client issue a…
9ed1a44 
…pache#5464

fabric8io/kubernetes-client#5463
XComp added a commit to XComp/flink that referenced this issue Jan 29, 2024
@XComp
[FLINK-34007][k8s] Upgrade k8s client to v6.9.0 to cover client issue a…
bb0e1fd 
…pache#5464

fabric8io/kubernetes-client#5463
XComp added a commit to XComp/flink that referenced this issue Jan 30, 2024
@XComp
[FLINK-34007][k8s] Upgrade k8s client to v6.9.2 to cover client issue a…
a1c6570 
…pache#5464

fabric8io/kubernetes-client#5463
XComp added a commit to XComp/flink that referenced this issue Jan 31, 2024
@XComp
[FLINK-34007][k8s] Upgrade k8s client to v6.9.2 to cover client issue a…
0719ea9 
…pache#5464

fabric8io/kubernetes-client#5463
XComp added a commit to XComp/flink that referenced this issue Jan 31, 2024
@XComp
[FLINK-34007][k8s] Upgrade k8s client to v6.9.2 to cover client issue a…
3fd82f5 
…pache#5464

fabric8io/kubernetes-client#5463
XComp added a commit to apache/flink that referenced this issue Feb 1, 2024
@XComp
[FLINK-34007][k8s] Upgrade k8s client to v6.9.2 to cover client issue #…
95417a4 
…5464

fabric8io/kubernetes-client#5463
XComp added a commit to XComp/flink that referenced this issue Feb 1, 2024
@XComp
[FLINK-34333][k8s] Upgrade k8s client to v6.9.2 to cover client issue a…
087ef9d 
…pache#5464 (cherry-picked from FLINK-34007)

fabric8io/kubernetes-client#5463

The change in KubernetesClientTestBase was necessary because of the change [apache#5369](fabric8io/kubernetes-client#5369) that ended up in v6.9.0 as well.
@XComp XComp mentioned this issue Feb 1, 2024
Merged
XComp added a commit to XComp/flink that referenced this issue Feb 1, 2024
@XComp
[FLINK-34333][k8s] Upgrade k8s client to v6.9.2 to cover client issue a…
bbef156 
…pache#5464 (cherry-picked from FLINK-34007)

fabric8io/kubernetes-client#5463

The change in KubernetesClientTestBase was necessary because of the change [apache#5369](fabric8io/kubernetes-client#5369) that ended up in v6.9.0 as well.
XComp added a commit to XComp/flink that referenced this issue Feb 5, 2024
@XComp
[FLINK-34333][k8s] Upgrade k8s client to v6.9.2 to cover client issue a…
ab126a8 
…pache#5464 (cherry-picked from FLINK-34007)

fabric8io/kubernetes-client#5463

The change in KubernetesClientTestBase was necessary because of the change [apache#5369](fabric8io/kubernetes-client#5369) that ended up in v6.9.0 as well.
XComp added a commit to XComp/flink that referenced this issue Feb 7, 2024
@XComp
[FLINK-34333][k8s] Upgrade k8s client to v6.9.2 to cover client issue a…
e8b38e2 
…pache#5464 (cherry-picked from FLINK-34007)

fabric8io/kubernetes-client#5463

The change in KubernetesClientTestBase was necessary because of the change [apache#5369](fabric8io/kubernetes-client#5369) that ended up in v6.9.0 as well.
XComp added a commit to apache/flink that referenced this issue Feb 13, 2024
@XComp
[FLINK-34333][k8s] Upgrade k8s client to v6.9.2 to cover client issue #…
35c5603 
…5464 (cherry-picked from FLINK-34007)

fabric8io/kubernetes-client#5463

The change in KubernetesClientTestBase was necessary because of the change [#5369](fabric8io/kubernetes-client#5369) that ended up in v6.9.0 as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
bug
Projects
None yet
Milestone
6.9.0
Development

Successfully merging a pull request may close this issue.

fix: ensure that onStopLeading is called shawkins/kubernetes-client
2 participants
@manusa @shawkins