Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reload config after every pull #37

Open
f1shl3gs opened this issue Dec 13, 2021 · 0 comments
Open

Do not reload config after every pull #37

f1shl3gs opened this issue Dec 13, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@f1shl3gs
Copy link
Owner

For now, after pulling config from http provider, vertex will reload the config even if nothing is changed. It's unnecessary and waste.
We should introduce a mechanism like event's Finalizer , after the config loaded the finalizer should be called, and the behavior should be defined by each Provider. For example, http provider should have a global static variable to store a Signature of config, it could be md5sum, sha2sum or some revision like etcd's, and it works like:

  1. Pull from remote server and get the signature of this config
  2. Check if the new received signature is equal to the global one, if yes go to 4, or go to 3
  3. Reload config, if success update the global signature, then go to 4
  4. Wait next pull then go to 1
@f1shl3gs f1shl3gs added the enhancement New feature or request label Dec 13, 2021
@f1shl3gs f1shl3gs added this to the V0.2.0 milestone Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant