Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for all text-decoration properties #360

Merged
merged 2 commits into from Jan 12, 2023
Merged

feat: Add support for all text-decoration properties #360

merged 2 commits into from Jan 12, 2023

Conversation

Rah1x
Copy link
Contributor

@Rah1x Rah1x commented Jan 12, 2023

  • Updated CSS definition and added support for all text-decoration related properties
  • Updated CSS test for the added properties
  • Updated CSS definition file and changed arrays into short syntax

@Rah1x Rah1x changed the title Add support for all text-decoration properties feat: Add support for all text-decoration properties Jan 12, 2023
@Rah1x Rah1x mentioned this pull request Jan 12, 2023
Closed
@ezyang
Copy link
Owner

ezyang commented Jan 12, 2023

For future reference, it will be easier for review if the refactor (array to short form) is done in a separate pr)

@ezyang ezyang merged commit 2d775c0 into ezyang:master Jan 12, 2023
@Rah1x
Copy link
Contributor Author

Rah1x commented Jan 12, 2023

Thanks a lot @ezyang :)

@Rah1x Rah1x deleted the allow-css-text-decoration-line branch January 30, 2023 05:54
github-actions bot pushed a commit that referenced this pull request Nov 17, 2023
@semantic-release-bot
chore(release): 4.17.0 [skip ci]
bbc513d 
# [4.17.0](v4.16.0...v4.17.0) (2023-11-17)

### Bug Fixes

* CSSTidy ImportantComments not handled properly ([#359](#359)) ([78a9b4d](78a9b4d))
* fix CI ([#361](#361)) ([9ec687c](9ec687c))
* Invalid scheme check in Attr.TargetBlank ([#363](#363)) ([0176ef4](0176ef4))
* semantic release ([#339](#339)) ([d82f3d9](d82f3d9))
* semantic release ([#341](#341)) ([e55fead](e55fead)), closes [#339](#339)
* Support for locales using decimal separators other than . (dot) ([#372](#372)) ([43f49ac](43f49ac))

### Features

* Add support for all text-decoration properties ([#360](#360)) ([2d775c0](2d775c0))
* Allows commas to be included in tel URI ([#389](#389)) ([ec92490](ec92490)), closes [#388](#388)

### Reverts

* Revert "fix: semantic release (#339)" (#340) ([3e83215](3e83215)), closes [#339](#339) [#340](#340)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rah1x @ezyang