package: bump standard #878
Merged
+229
−225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
LinusU
reviewed
Apr 24, 2020
LinusU
reviewed
Apr 24, 2020
LinusU
reviewed
Apr 24, 2020
LinusU
reviewed
Apr 24, 2020
|
Hehe, I thought I could do them all from the GitHub web interface 😄 but one was too long |
|
Hehe, we are working at the same time 😂 |
|
haha 😂 good catch, though! I just did a full replace operation and pushed the fixes 👍 |
|
hehe. Why I am awake at 4am, who knows!! |
|
Thanks for this!! |
nevilm-lt
pushed a commit
to nevilm-lt/multer
that referenced
this pull request
Apr 21, 2022
package: bump standard
nevilm-lt
pushed a commit
to nevilm-lt/multer
that referenced
this pull request
Apr 22, 2022
package: bump standard
nevilm-lt
pushed a commit
to nevilm-lt/multer
that referenced
this pull request
Apr 22, 2022
package: bump standard
himanshiLt
pushed a commit
to himanshiLt/multer
that referenced
this pull request
Jun 24, 2022
package: bump standard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades
standardwhich resolves the CI issue on Node.js 4. Of course some rules changes, especially aroundassertusage, so I made what seemed like the minimal changes for it. Sinceassert.deepEqualis deprecated andassert.deepStrictEqualdoes not exist on Node.js 0.10, I pulled indeep-equalso the tests were still nice and readable.