- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tailing comma in arguments #623
Conversation
Althoug this is nice feature, I think for not is not needed in Expr. as most of the time expressions is one line. We may return later to this and change our decision. |
Although most of the time the expression is a single line, I still think this feature makes sense. This is considered from the perspective of syntactic consistency of expr. Because I discovered that expr parser supports ignoring the last comma on type of array or type of map, which is much like Python unlike JSON. For example, the following statements can be parsed via expr parser
So from this point of view, many users may naturally think that the last comma will be ignored by the parser. However, if the user finds that the function call is not allowed to add a comma at the end. This can be confusing. |
Hmm. This is true. We do allow comma in arrays & maps. Let me think on it bit more. |
685ad2c
to
2eed2d8
Compare
Well, let's add support for this! |
allow the last argument append with comma in func expr.
make below expr can be parsed ok.