Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using body[data-theme] instead of html[data-theme] breaks using theme switcher #194

Open
AliveDevil opened this issue May 16, 2024 · 1 comment
Labels

Comments

@AliveDevil
Copy link

Describe the bug

A theme switcher component sets data-theme on html-element, not on html.body, as html attributes aren't inherited, Tabs break when using html.data-theme.

image

Reproduce the bug

  1. Create project with sphinx-rtd, sphinx-tabs and sphinx-rtd-dark-mode
  2. Create tab
  3. Switch theme

List your environment

No response

@AliveDevil AliveDevil added the bug label May 16, 2024
Copy link

welcome bot commented May 16, 2024

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant