Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for Sphinx 7.2 #179

Merged
merged 6 commits into from Oct 22, 2023
Merged

Fix tests for Sphinx 7.2 #179

merged 6 commits into from Oct 22, 2023

Conversation

MeggyCal
Copy link
Contributor

Sphinx changed “Permalink” to “Link” in sphinx-doc/sphinx#10049.

I will try to make it backwards-compatible in the next commit.

@welcome
Copy link

welcome bot commented Sep 19, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@foster999
Copy link
Collaborator

foster999 commented Oct 21, 2023

The updated regression outputs are working, but the test fixture change isn't working for Python 3.7 and 3.8 which use older versions of sphinx. Your change is in the doctree regression, but I think the change is actually in the HTML.

If you want to try to address this look into using beautifulsoup to remove the title attribute from those elements in the HTML (regardless of sphinx version). This would allow us to ignore any other changes to that text in future too

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@foster999
Copy link
Collaborator

Decided that we should stop testing earlier versions of sphinx (and therefore Python), so we don't have to keep updating tests for non-functional changes to sphinx and its dependencies.

@foster999 foster999 merged commit 1256852 into executablebooks:master Oct 22, 2023
8 checks passed
@welcome
Copy link

welcome bot commented Oct 22, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants