Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer needed declare_namespace() #177

Merged
merged 1 commit into from Jul 12, 2023
Merged

Remove no longer needed declare_namespace() #177

merged 1 commit into from Jul 12, 2023

Conversation

kloczek
Copy link
Contributor

@kloczek kloczek commented Jul 6, 2023

This fix removes declare_namespace() which is no longer needed. it used old style namespaces which has been using pkg_resources module which is part of the setuptools and which is as well depreceted now.

This fix removes declare_namespace() which is no longer needed.
it used old style namespaces which has been using `pkg_resources` module
which is part of the `setuptools` and which is as well depreceted now.

Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
@welcome
Copy link

welcome bot commented Jul 6, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (9431223) 97.27% compared to head (034d5f8) 97.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   97.27%   97.26%   -0.02%     
==========================================
  Files           2        2              
  Lines         220      219       -1     
==========================================
- Hits          214      213       -1     
  Misses          6        6              
Flag Coverage Δ
pytests 97.26% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sphinx_tabs/__init__.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@foster999
Copy link
Collaborator

Thanks, I hadn't come across this before and wasn't aware that it was redundant. Tests are all passing 👍🏻

@foster999 foster999 merged commit cd11906 into executablebooks:master Jul 12, 2023
10 checks passed
@welcome
Copy link

welcome bot commented Jul 12, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@kloczek
Copy link
Contributor Author

kloczek commented Jul 12, 2023

Thank you 👍 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants