Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update Materials Design Icons to v4.0.0-46-gc9e5528 #69

Merged
merged 6 commits into from Jul 30, 2022

Conversation

2bndy5
Copy link
Contributor

@2bndy5 2bndy5 commented Jun 1, 2022

This adds 421 icons; some are fresh icons, and some are just different sizes. Threre might be some name changes, but it should be current with what is shown on the https://fonts.google.com/icons (as referenced by this ext's docs).

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #69 (88698ef) into main (3e3df8d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files          11       11           
  Lines         917      917           
=======================================
  Hits          816      816           
  Misses        101      101           
Flag Coverage Δ
pytests 88.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3df8d...88698ef. Read the comment docs.

@chrisjsewell
Copy link
Member

thanks, is there some kind of versioning for these icons though?

@2bndy5
Copy link
Contributor Author

2bndy5 commented Jun 14, 2022

Unfortunately, no. The Google team isn't very forthcoming about the material icons repo. They recently stopped accepting new icons from outside their "inner circle". You may already be aware of the third party MDI node.js pkg(s) because they've given up maintaining npm releases on their end also.

The last release (v4.0.0 long ago) was a huge re-organization of the repo that isn't very Windows friendly. This is why I use a shortened sha in my repo that compiles these JSONs once a month.

@2bndy5
Copy link
Contributor Author

2bndy5 commented Jun 16, 2022

If you want I could add the SHA somewhere. On my repo's CI, I capture the git describe and append it to the artifact's name. I could adjust the CI to add a txt file
(probably called "material-icons_VERSION") that contains the full SHA and/or git describe result.

These assets submitted here are compiled from v4.0.0-40-g14a258 of the google's material icons repo.


My repo's CI is scheduled to run once a month, and I have to check in on its progress (every other month) to keep the CI workflow enabled.

@2bndy5 2bndy5 marked this pull request as draft July 8, 2022 05:49
@2bndy5
Copy link
Contributor Author

2bndy5 commented Jul 8, 2022

Huge update to the material icons repo today. I'll update this PR in accordance (hopefully tomorrow). I'll also add a versioned identifier (probably using SHA in a separate file).

@2bndy5 2bndy5 marked this pull request as ready for review July 9, 2022 13:46
@2bndy5
Copy link
Contributor Author

2bndy5 commented Jul 9, 2022

OK. I've updated the JSONs using the latest commit from google's MDI repo.

I also added a material-icons_VERSION.txt file that includes:

  1. a link to google's repo
  2. the abbreviated version (containing the number of commits since tagged)
  3. the full SHA of the commit used.

@chrisjsewell
Copy link
Member

chrisjsewell commented Jul 30, 2022

I also added a material-icons_VERSION.txt file that includes:

thanks for this @2bndy5, sorry I was still differing a little because of the large diff.
I thought it would be nice to know exactly what was had changed, in available icon names.
So I run this before and after your PR, and compared.

data = {}
base = Path("sphinx_design/compiled")
for path in base.glob("material_*.json"):
    mtype = path.name[9:-5]
    for name in json.loads(path.read_text()):
        data.setdefault(name, [])
        data[name].append(mtype)
base.joinpath("names_material.json").write_text(json.dumps(data, indent=2, sort_keys=True))

As you can see (by the right bar), there are only additions, which in my book means no breaking changes 👌

image

@chrisjsewell chrisjsewell changed the title update MD compiled JSONs ⬆️ Update Materials Design Icons to v4.0.0-46-gc9e5528 Jul 30, 2022
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers!

@chrisjsewell chrisjsewell merged commit b44c8fc into executablebooks:main Jul 30, 2022
@2bndy5
Copy link
Contributor Author

2bndy5 commented Jul 30, 2022

Again, I wish the Google team was a lot more explanatory about their changes to the icons repo. The last big change was from a PR labeled "update icons" with no description. The merge commit was so large that github couldn't display the diff...

@2bndy5 2bndy5 deleted the update-MD-icons branch July 30, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants