Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyData theme CSS resulted in unexpected changes to this theme's style #765

Closed
Gouvernathor opened this issue Oct 5, 2023 · 4 comments · Fixed by #775
Closed

PyData theme CSS resulted in unexpected changes to this theme's style #765

Gouvernathor opened this issue Oct 5, 2023 · 4 comments · Fixed by #775

Comments

@Gouvernathor
Copy link

Gouvernathor commented Oct 5, 2023

Recent changes to the style have made the dark theme's background bluish instead of dark grey, and the hovered links purple instead of blue.
The preceding style was much better so I believe that change should be reverted, or at least an option provided to opt-out and go back to the former colors.

Former :
image
New :
image

@Gouvernathor
Copy link
Author

I also wouldn't mind disabling the "Back to top" button spawning in the bottom half of the screen, at lease when you're not on a phone. It's not strictly related to the theme color issue, but I don't want to spam the tracker.

@choldgraf
Copy link
Member

A lot of these were inherited from the PyData Sphinx Theme, which made these updates to improve the accessibility of the theme in general. I don't think we should revert changes that we know improve accessibility (e.g. color contrast) just because we think they don't look as good, but if we can identify improvements that are equally as accessible, then I'm fine implementing them here.

@Gouvernathor
Copy link
Author

Gouvernathor commented Nov 9, 2023

With the font color remaining stark white, since turning the background from pitch black to dark blue decreases the contrast between them, I don't understand how it improves accessibility,
I can understand accessibility reasons for having the hovered links purple instead of brighter blue, it feels weird since it's a deviation from the standard but if the accessibiliity reasons are solid I guess you have to start somewhere.
If you have a link to the issue or PR where that was decided, it would be greatly appreciated (found it, pydata/pydata-sphinx-theme#1174).

For the "back to top" button, I doubt that's related to accessibility (but I don't think you were saying that).

@choldgraf choldgraf changed the title Revert changes to the style PyData theme CSS resulted in unexpected changes to this theme's style Nov 9, 2023
@choldgraf
Copy link
Member

I just added some changes to address some of these in #775 - can you take a look there? I think it'll be more productive to make some minor adjustments to this theme rather than to re-litigate the long accessibility discussions that happened already in the pydata theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants