Better early return for add_launch_buttons if no launch buttons #693
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice - this looks correct to me. Could you just add a test to make sure that if none if them are there, then there is no launch buttons dropdo container on the page? |
choldgraf
reviewed
Feb 26, 2023
| not launch_buttons | ||
| or not _is_notebook(app, pagename) | ||
| or not any( | ||
| launch_buttons[key] |
There was a problem hiding this comment.
Shouldnt we use launch_buttons.get(key) in case one is not present so we don't raise a key error?
|
Congrats on your first merged pull request in this project! 🎉 |
|
actually, no worries I will add a test in #691 - many thanks for this improvement :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes jupyter-book/jupyter-book#1463
See jupyter-book/jupyter-book#1463 (comment)
Is it enough?