Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Substitution extension #777

Merged
merged 1 commit into from
Jun 6, 2023
Merged

👌 IMPROVE: Substitution extension #777

merged 1 commit into from
Jun 6, 2023

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Jun 6, 2023

Allow any value type (including dict, list, datetime) and emit a myst.substitution warning for errors in resolving the substitution.

Allow any value type (dict, list, datetime) and emit a `myst.substitution` warning for errors in resolving the substitution.
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.23 🎉

Comparison is base (b043351) 90.00% compared to head (e639ce7) 90.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
+ Coverage   90.00%   90.23%   +0.23%     
==========================================
  Files          23       23              
  Lines        2970     2970              
==========================================
+ Hits         2673     2680       +7     
+ Misses        297      290       -7     
Flag Coverage Δ
pytests 90.23% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_parser/config/dc_validators.py 83.63% <100.00%> (+0.30%) ⬆️
myst_parser/config/main.py 86.26% <100.00%> (ø)
myst_parser/mdit_to_docutils/base.py 93.41% <100.00%> (+0.72%) ⬆️
myst_parser/warnings_.py 96.22% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chrisjsewell chrisjsewell merged commit 3a6bbb1 into master Jun 6, 2023
21 checks passed
@chrisjsewell chrisjsewell deleted the substitutions branch June 6, 2023 09:43
@firasm
Copy link

firasm commented Jun 6, 2023

Thank you, this is great!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider expanding substitutions to include nested substitutions Date no longer allowed in substitutions
2 participants