fix: text disappearing on edit (#8558) #8624
Merged
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@mtolmacs Hi, is this solution suiting your standard? |
dwelle
approved these changes
Oct 17, 2024
|
Hey @ObstinateM, thanks for the PR!
Yeah, we were leaving the state update refactors for a larger rewrite that would implement its own scheduler and state mgmt, but it's not clear how soon that will happen. |
Jauhen
pushed a commit
to Jauhen/excalidraw
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #8558 (due to race condition)
The issue was consistently happening on MacOS and safari.
I use the same strategy that is use before, with the use of
flushSync(). We should update this in finalize action, like with via keyboard trigger