Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow same origin for all necessary domains #7889

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

dwelle
Copy link
Member

@dwelle dwelle commented Apr 13, 2024

fix #7888

I've also removed dddice.com because it seems the embed isn't working correctly anymore even despite allow-same-origin (though we'd also likely not want to allow that flag for this domain, going forward). /cc @FilBot3

Copy link

vercel bot commented Apr 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Apr 13, 2024 4:23pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Apr 13, 2024 4:23pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Apr 13, 2024 4:23pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Apr 13, 2024 4:23pm

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 64.35% (🎯 70%) 48479 / 75327
🔴 Statements 64.35% (🎯 70%) 48479 / 75327
🔴 Functions 65.03% (🎯 68%) 1460 / 2245
🟢 Branches 80.17% (🎯 70%) 5839 / 7283
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/element/embeddable.ts 31.23% 23.07% 42.85% 31.23% 76-77, 80-255, 258-292, 300-319, 333-350, 360-361, 365-366, 369-370, 374-375, 385-386, 388-410
Generated in workflow #2270

@dwelle dwelle merged commit da2e507 into master Apr 13, 2024
13 checks passed
@dwelle dwelle deleted the dwelle/allow-same-origin-for-more-domains branch April 13, 2024 16:51
dwelle added a commit to dwelle/excalidraw that referenced this pull request Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Youtube embeddables are black - not playing
1 participant