Do not allow failed patching to stop execution #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayofdoom
force-pushed
the
jay/PatchGracefully
branch
2 times, most recently
from
7884b94
to
cdf1fa6
Compare
|
Before: After: Example from https://zuul.opendev.org/t/openstack/build/63914f9dc9e24e1180eea22bfd92e13c but screenshot posted since that link will bitrot :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #907 +/- ##
=====================================
Coverage 56% 56%
=====================================
Files 89 89
Lines 9717 9722 +5
Branches 1810 1810
=====================================
+ Hits 5457 5462 +5
Misses 3885 3885
Partials 375 375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jayofdoom
force-pushed
the
jay/PatchGracefully
branch
from
cdf1fa6
to
2f6b114
Compare
|
Pushed something that should make the coverage job a little happier :) |
jayofdoom
force-pushed
the
jay/PatchGracefully
branch
2 times, most recently
from
f231d0f
to
6540155
Compare
There are some cases where monkey_patching cannot always be performed early enough; such as sphinx autodoc importing. To help handle these cases, exceptions during patching are logged and execution is allowed to continue. This fixed an issue in OpenStack Manila docs generation caused by an upgrade to eventlet 0.35.0.
jayofdoom
force-pushed
the
jay/PatchGracefully
branch
from
6540155
to
48b1ad1
Compare
4383
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some cases where monkey_patching cannot always be performed early enough; such as sphinx autodoc importing. To help handle these cases, exceptions during patching are logged and execution is allowed to continue.
This fixed an issue in OpenStack Manila docs generation caused by an upgrade to eventlet 0.35.0.