Add get_server_info to db_pool.py #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4383
approved these changes
Jan 17, 2024
|
Wow, that was a long time ago! :-D I guess step one is to rebase this! Feel free to do that and push and so on if you have time... I might have time to look at it in the weekend otherwise. |
|
hm... something went wrong during your rebase. All tests are failing and your addition does not seems in the right place in the code like before. Please check |
Django uses this for example.
|
I guess it should be like this now.. ? |
|
Looks better, thanks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #324 +/- ##
=====================================
Coverage 55% 55%
=====================================
Files 90 90
Lines 9878 9959 +81
Branches 1831 1855 +24
=====================================
+ Hits 5460 5537 +77
- Misses 4044 4047 +3
- Partials 374 375 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django uses this for example.