Multiple tsconfigs used when building a workspace with aliases

[ilijapuaca]

This seems to be a regression (or a change in behavior) starting with v0.19 - our builds started failing after the upgrade with errors indicating that paths for one of the aliases was not being resolved correctly. After spending some time going through the verbose log, it turned out that the issue happens because tsconfig of the aliased package seems to come into the play when previously that supposedly wasn't the case.

Putting a small repro in place seems difficult as yarn workspace setup may be involved as well at some point. We basically have a git submodule in our workspace that has a somewhat complicated setup by itself that we set up aliases to in our own codebase, hence the presence of tsconfig in the module itself.

Previously aliases were picked up just fine, but after upgrading to v0.19 builds fail as wrong files (not the ones that paths points to) get picked up. After removing tsconfig.json out of the aliased package things seem to work fine again, so my assumption is that that the tsconfig that's present in the submodule is somehow taken into account now while transpiling its code (although it has nothing to do with the initial entry point) where it previously wasn't.

I've put together this setup which is the closest I can get to modeling a similar setup without having to put together an entire repo with yarn, which I'll do if need be, but I thought it'd be worthwhile putting this up first as someone might have an idea what the regression/change might've been here.

[ZuBB]

It sounds similar to what is described in #3354

[ilijapuaca]

Perhaps worth noting - the submodule which contains tsconfig that previously wasn't being taken into account has paths set to such:

  "paths": {
      "*": ["*"]
    }

Removing this makes things work the way they have < 0.19 🤷‍♂️

[evanw]

I just fixed #3354 and I'm closing this issue under the assumption that it's a duplicate.

I'm not sure what the link in the original post is trying to demonstrate as everything appears to be working fine to me and esbuild's behavior is not different between 0.18.x and 0.19.x on that code. So I can't currently reproduce what this post is describing.