Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-flight DecodePatch validation: Issue #177 #180

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

radwaretaltr
Copy link
Contributor

Pre-flight Patch validation in DecodePatch

@radwaretaltr radwaretaltr changed the title Pre-flight DecodePatch validation Pre-flight DecodePatch validation: Issue #177 Aug 3, 2023
@radwaretaltr
Copy link
Contributor Author

Hi @evanphx,

Can you please assist and take a look at the build failure we are getting.
Not sure it's related to our changes.

@evanphx
Copy link
Owner

evanphx commented Aug 10, 2023

Wow, that's odd.

@evanphx
Copy link
Owner

evanphx commented Aug 10, 2023

@radwaretaltr Could you rebase and try again? The go version was bumped to 1.18...

@radwaretaltr
Copy link
Contributor Author

@radwaretaltr Could you rebase and try again? The go version was bumped to 1.18...

Done.

@radwaretaltr
Copy link
Contributor Author

Hi @evanphx,

Is it possible to proceed with this PR? Looks like there are 2 workflows awaiting approval.

@sambercovici
Copy link

Hi @evanphx
Can you please provide an estimate when you can review this PR/merge?

Thanks, Sam.

@evanphx evanphx merged commit eed7579 into evanphx:master Sep 11, 2023
1 of 2 checks passed
bryan-cox added a commit to bryan-cox/hypershift that referenced this pull request Nov 20, 2023
This is no longer valid.
https://github
.com/evanphx/json-patch/pull/180/files

Signed-off-by: Bryan Cox <brcox@redhat.com>
bryan-cox added a commit to bryan-cox/hypershift that referenced this pull request Nov 20, 2023
This is no longer valid.
https://github
.com/evanphx/json-patch/pull/180/files

Signed-off-by: Bryan Cox <brcox@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants