Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmptyState prop description has different type than in react component #546

Closed
surajeaton opened this issue Feb 29, 2024 · 0 comments · Fixed by #550
Closed

EmptyState prop description has different type than in react component #546

surajeaton opened this issue Feb 29, 2024 · 0 comments · Fixed by #550
Assignees
@surajeaton
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected needs-review Issues that we would like to revisit/review

Comments

@surajeaton
Copy link
Contributor

Describe the bug / expected behavior

EmptyState prop description has different type than in react component

What are the steps to reproduce?

  1. Check https://github.com/etn-ccis/blui-react-component-library/blob/b6dae00bda5bb14071a0cada2a699509a36d205c/components/src/core/EmptyState/EmptyState.tsx#L29
  2. Check

    blui-react-native-component-library/components/src/core/EmptyState/EmptyState.tsx

    Line 48 in 2b8c800

    description?: string;
  3. The description prop has ReactNode type in react comp library and string in react native comp library

Screenshots / Screen recording

Code snippet / Link to minimum reproduction example

CODE HERE

Your environment information

Found while using EmptyState in https://github.com/etn-ccis/blui-react-native-workflows/blob/release/R31/login-workflow/src/screens/SuccessScreen/SuccessScreenBase.tsx

Suggested fix

We may need to update react native comp library's EmptyState description prop type to ReactNode

Anything else to add?
@surajeaton surajeaton added bug Something not working as expected needs-review Issues that we would like to revisit/review brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering labels Feb 29, 2024
@surajeaton surajeaton self-assigned this Mar 6, 2024
@surajeaton surajeaton mentioned this issue Mar 6, 2024
Merged
@surajeaton surajeaton mentioned this issue Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@surajeaton surajeaton

Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected needs-review Issues that we would like to revisit/review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug/546 title description props Emptystate etn-ccis/blui-react-native-component-library
1 participant
@surajeaton