Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose InfoListItemProps on DrawerNavItem #252

Closed
daileytj opened this issue Mar 16, 2022 · 1 comment · Fixed by #330
Closed

Expose InfoListItemProps on DrawerNavItem #252

daileytj opened this issue Mar 16, 2022 · 1 comment · Fixed by #330
Assignees
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature
Milestone

Comments

@daileytj
Copy link
Contributor

daileytj commented Mar 16, 2022

Describe the desired behavior

Add a new prop called InfoListItemProps to the DrawerNavItem component. The property should be passed through to the underlying InfoListItem component so that users can update additional props on the InfoListItem through the DrawerNavItem.

See the additional context items below for details on implementation and be sure to remove the hardcoded testId and accessibilityLabel that was added on the InfoListItem TouchableOpacity component as a quick solution for this.

Describe the current behavior

Currently, some of the properties of the InfoListItem are not exposed through the DrawerNavItem. In particular, this issue arose from a need to apply a testID to the underlying TouchableOpacity to simulate clicks in an E2E test suite.

Is this request related to a current issue?

Yes, as per above, this is related to being able to set a testID on the TouchableOpacity for E2E testing.

Additional Context

You can read some of the initial discussion around this issue on this PR: https://github.com/brightlayer-ui/react-native-component-library/pull/251

This functionality has already been implemented in the React components. You can refer to the implementation there as a guide: https://github.com/brightlayer-ui/react-component-library/blob/dev/components/src/core/Drawer/DrawerNavItem/DrawerNavItem.tsx#L95

This may require additional tweaks in the InfoListItem to properly apply any of these props.

@daileytj daileytj added enhancement Request for improvement or new feature needs-review Issues that we would like to revisit/review labels Mar 16, 2022
@daileytj daileytj added this to the 6.1.0 milestone Mar 16, 2022
@bkarambe
Copy link
Contributor

Do not remove the default/hardcoded test-id's, override them with values passed in InfoListItemProps.

@bkarambe bkarambe removed the needs-review Issues that we would like to revisit/review label Apr 13, 2022
@joebochill joebochill added needs-review Issues that we would like to revisit/review hacktoberfest2022 Issues shared for contributions by the Hacktoberfest community in 2022 hacktoberfest Issues shared for contributions by the Hacktoberfest community and removed needs-review Issues that we would like to revisit/review labels Sep 26, 2022
@daileytj daileytj removed this from the 7.1.0 milestone Nov 28, 2022
@daileytj daileytj removed hacktoberfest2022 Issues shared for contributions by the Hacktoberfest community in 2022 hacktoberfest Issues shared for contributions by the Hacktoberfest community labels Nov 28, 2022
@daileytj daileytj added this to the 7.1.0 milestone Nov 28, 2022
@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 5, 2023
@surajeaton surajeaton self-assigned this Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature
4 participants