Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrawerNavGroup Title Divider Prop #187

Closed
daileytj opened this issue Aug 12, 2021 · 1 comment · Fixed by #329
Closed

DrawerNavGroup Title Divider Prop #187

daileytj opened this issue Aug 12, 2021 · 1 comment · Fixed by #329
Assignees
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature
Milestone

Comments

@daileytj
Copy link
Contributor

daileytj commented Aug 12, 2021

Describe the desired behavior

A user should be able to toggle on/off the divider that comes after the DrawerNavGroup title via a prop (e.g., titleDivider: boolean)

Describe the current behavior

If the DrawerNavGroup has a title, a divider is provided below the title by default and cannot be disabled.

Is this request related to a current issue?

No

Additional Context

We may want to have a titleDividerPosition: 'top' | 'bottom' prop as well, so that the divider can be positioned above or below the DrawerNavGroup title depending on the context.

The titleDivider prop should have a default value of true to maintain backwards compatibility.

@daileytj daileytj added enhancement Request for improvement or new feature needs-review Issues that we would like to revisit/review labels Aug 12, 2021
@daileytj
Copy link
Contributor Author

Let's keep the logic simple here and not add the titleDividerPosition. The user can add a divider where they want between the nav groups.

@daileytj daileytj removed the needs-review Issues that we would like to revisit/review label Aug 18, 2021
@joebochill joebochill added this to the 6.1.0 milestone Dec 27, 2021
@joebochill joebochill added needs-review Issues that we would like to revisit/review hacktoberfest2022 Issues shared for contributions by the Hacktoberfest community in 2022 hacktoberfest Issues shared for contributions by the Hacktoberfest community and removed needs-review Issues that we would like to revisit/review labels Sep 26, 2022
@daileytj daileytj removed this from the 7.1.0 milestone Nov 28, 2022
@daileytj daileytj removed hacktoberfest2022 Issues shared for contributions by the Hacktoberfest community in 2022 hacktoberfest Issues shared for contributions by the Hacktoberfest community labels Nov 28, 2022
@daileytj daileytj added this to the 7.1.0 milestone Nov 28, 2022
@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 5, 2023
@surajeaton surajeaton self-assigned this Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature
3 participants