Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header should blend with status bar on Android devices #186

Closed
joebochill opened this issue Aug 10, 2021 · 2 comments
Closed

Header should blend with status bar on Android devices #186

joebochill opened this issue Aug 10, 2021 · 2 comments
Labels
android Affects Android implementation brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature
Milestone

Comments

@joebochill
Copy link
Collaborator

Describe the desired behavior

The header should blend behind the StatusBar on android devices (particularly those with a notch).

image

Describe the current behavior

Currently the Header is drawn below the StatusBar on Android devices.

image

Is this request related to a current issue?

This is related to work from the EMCB project.

Additional Context

The StatusBar has a translucent prop that will allow us to draw content behind it (if we set backgroundColor to 'transparent'). However, setting this property currently causes some misalignment with the content because SafeAreaView does not do anything on Android (see facebook/react-native#17371). We will need to manually add a top padding in the Header on Android devices.

@joebochill joebochill added enhancement Request for improvement or new feature android Affects Android implementation needs-review Issues that we would like to revisit/review labels Aug 10, 2021
@joebochill joebochill changed the title Header should support notched Android devices Header should blend with status bar on Android devices Aug 10, 2021
@daileytj daileytj removed the needs-review Issues that we would like to revisit/review label Aug 18, 2021
@daileytj
Copy link
Contributor

daileytj commented Aug 18, 2021

The quick and dirty solution above still needs some investigation since it leaves the middle content slightly visible when collapsed.

@daileytj
Copy link
Contributor

daileytj commented Feb 6, 2023

Fixed by #339

@daileytj daileytj closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Affects Android implementation brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature
Development

No branches or pull requests

2 participants