Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setThrottleParams not using passed-in values #4663

Closed
ryanio opened this issue Mar 25, 2024 · 1 comment
Closed

setThrottleParams not using passed-in values #4663

ryanio opened this issue Mar 25, 2024 · 1 comment
Assignees
@ricmoo
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published. v6 Issues regarding v6

Comments

@ryanio
Copy link

ryanio commented Mar 25, 2024

Ethers Version

6.11.1

Search Terms

throttle, fetch

Describe the Problem

It doesn't seem values passed to setThrottleParams are working.
@ricmoo said:

I see the .clone being used, but since the throttle isn’t copied, it is falling back to the default which is 12. Good catch.

Code Snippet

No response

Contract ABI

No response

Errors

No response

Environment

No response

Environment (Other)

No response
@ryanio ryanio added investigate Under investigation and may be a bug. v6 Issues regarding v6 labels Mar 25, 2024
@ricmoo ricmoo added bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. next-patch Issues scheduled for the next arch release. and removed investigate Under investigation and may be a bug. labels Mar 26, 2024
ricmoo added a commit that referenced this issue Mar 27, 2024
@ricmoo
Fix ignored throttle parameters (#4663).
12772e9
@ricmoo
Copy link
Member

ricmoo commented Apr 17, 2024

Fixed in v6.12.0.

Thanks! :)

@ricmoo ricmoo closed this as completed Apr 17, 2024
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. next-patch Issues scheduled for the next arch release. labels Apr 17, 2024
@snyk-io snyk-io bot mentioned this issue May 21, 2024
Open
@X-oss-byte X-oss-byte mentioned this issue May 22, 2024
Open
@MTthoas MTthoas mentioned this issue May 23, 2024
Merged
@X-oss-byte X-oss-byte mentioned this issue May 24, 2024
Open
This was referenced May 26, 2024
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricmoo ricmoo

Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published. v6 Issues regarding v6
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryanio @ricmoo