Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out Infura project id #2904

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Apr 6, 2023

What was wrong?

Someone was spamming our project id, so swapped out the key and added another layer of obfuscation.

How was it fixed?

Removed old project key from repo and revoked permissions. Added new environment variable to CI

Todo:

  • Add entry to the release notes - should we add to release notes?

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kclowes kclowes marked this pull request as ready for review April 6, 2023 17:28
@kclowes kclowes requested review from fselmo and pacrob April 6, 2023 17:30
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! About time we made this change too 😆. Internal newsfragment if you want, but lgtm! 👍🏼

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kclowes kclowes merged commit 85d91ce into ethereum:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants