-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENS doc menu format #6699
ENS doc menu format #6699
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with Cloudflare Pages
|
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6699 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 214 214
Lines 8171 8171
Branches 2200 2200
=======================================
Hits 7472 7472
Misses 699 699
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@jdevcs pls let me know if u agree with the above changes (just added the collapsible to keep the same format, and changed the 📦 emoji to keep it equal to the web3eth package) |
Description
ENS doc menu format
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.